Remove and comment out code related to banner #182
Conversation
|
Visit the preview URL for this PR (updated for commit ed94e34): https://nwplus-io--pr182-remove-banner-6enbld32.web.app (expires Sat, 09 Dec 2023 18:52:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a778397fecec2eb8f19e28d7b9fa723113d13f3d |
components/Hero.js
Outdated
| @@ -13,7 +13,7 @@ const HeroContainer = styled.div` | |||
| padding-bottom: 69%; | |||
| background: url(/assets/hero_illustration.svg); | |||
| background-repeat: no-repeat; | |||
| background-position: center; | |||
| background-position: top; | |||
| background-size: contain; | |||
| padding-top: 134px; | |||
There was a problem hiding this comment.
Would recommend removing padding-top as well. This was added to shift down the hero, but now without the banner it's shifted down too much (e. g. nwPlus text is a bit low and might be way too low on smaller screens)
There was a problem hiding this comment.
Good catch, I didn't notice that
components/NavBar.js
Outdated
| @@ -233,25 +232,22 @@ const NavBar = () => { | |||
| }; | |||
|
|
|||
| const handleScroll = () => { | |||
| let lastScroll = 0 | |||
| var lastScroll = 0; | |||
There was a problem hiding this comment.
Just wanted to double-check if var is really needed here – seems like lastScroll is only used within scope. Correct me if I'm wrong though!
There was a problem hiding this comment.
var is outdated - I'll change it to let
Description
Other considerations