2023 fall hiring updates - CAP-related changes #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase CAP-related fields
|
Visit the preview URL for this PR (updated for commit 6b67b34): https://nwplus-io--pr171-fall-2023-hiring-upd-8946uih8.web.app (expires Mon, 25 Sep 2023 21:54:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a778397fecec2eb8f19e28d7b9fa723113d13f3d |
michelleykim
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
isHiringCapandCAPFormLinkfields on Firebase DEV ONLYOther considerations
if approved, prod firebase will need to add
isHiringCapandCAPFormLinkfirebase fieldnoticed that the text relying on the
config?.featureFlags?.isHiringfield tends to load a little slower than the rest of the content due to the extra conditional check - would be open to suggestions on how to refactor the code to fix this or if this is desirableFUTURE CHANGES: implement Admin/CMS functionality to be able to change the above firebase fields through Admin/CMS instead of manually through firebase UI
