Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate sponsors into tiers #382

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

alvinkam33
Copy link

idk how this will look with the actual sponsors, but if there is an issue i can revisit. lmk if i should add a header for each of the tiers

@alvinkam33 alvinkam33 requested a review from meleongg November 7, 2023 07:36
Copy link

@AbdullahWins AbdullahWins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done!

Copy link

github-actions bot commented Nov 7, 2023

Visit the preview URL for this PR (updated for commit c43c274):

https://dev-nwplus-root--pr382-hackcamp2023-sponsor-8z3cu0lw.web.app

(expires Sat, 18 Nov 2023 05:50:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ca465d4a689cc01bf206252b60f82f45b4ba90eb

{Object.keys(sponsors).sort((a, b) => sponsorTierOrder[a] - sponsorTierOrder[b]).map((key) => (
<SponsorTier>
{sponsors[key].map((sponsor) => (
<SponsorLogo src={sponsor.imgURL}/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to link to the link contained in sponsor.link?
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yer added

@alvinkam33 alvinkam33 requested a review from meleongg November 8, 2023 05:47
Copy link
Member

@meleongg meleongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@meleongg meleongg merged commit b760513 into hackcamp2023_dev Nov 8, 2023
5 of 6 checks passed
@meleongg meleongg deleted the hackcamp2023_sponsor_tiers branch November 8, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants