Hackcamp2023 animation sam #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 4871169): https://dev-nwplus-root--pr361-hackcamp2023-animati-f8upe7oz.web.app (expires Sat, 14 Oct 2023 23:17:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: ca465d4a689cc01bf206252b60f82f45b4ba90eb |
michelleykim
reviewed
Oct 4, 2023
| @@ -145,6 +169,48 @@ const StyledTitle = styled(Header2)` | |||
| } | |||
| ` | |||
|
|
|||
| const waving = keyframes` | |||
There was a problem hiding this comment.
honestly, the animation looks fine to me. But if you want to make it perfect I think you can try using translateX and translateY along with rotate here
michelleykim
approved these changes
Oct 4, 2023
michelleykim
changed the base branch from
hackcamp2023_main
to
hackcamp2023_dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
animations for ufo light, mushroom glow, deer and bear wave, sea creature movement, space nugget bob, bubble rise and disaapear
Other considerations