-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hackcamp2023 animations alvin #360
Conversation
alvinkam33
commented
Oct 1, 2023
•
edited
Loading
edited
- Finished required animations:
- portal float up/down
- mascots floating in (parallax scroll)
- fishing mascot bobbing up/down
- stats numbers increasing from 0 when scrolling into view
- glow effect on mushroom stems
…-templates into hackcamp2023_animations_alvin
Visit the preview URL for this PR (updated for commit 4e55d60): https://dev-nwplus-root--pr360-hackcamp2023-animati-5r2c391i.web.app (expires Fri, 13 Oct 2023 04:29:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: ca465d4a689cc01bf206252b60f82f45b4ba90eb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the preview is a bit slow on load and some animations (especially the ones going up & down) looks a bit choppy but it might totally because of my 43 tabs. These are minor things, so if melvin's ok with them I'm fine merging it tho lol
let startValue = 0 | ||
const endValue = parseInt(valueDisplay.getAttribute('data-val')) | ||
const id = valueDisplay.getAttribute('id') | ||
const duration = Math.floor(interval / endValue) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious if this was an arbitrary value choice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was pretty arbitrary yeah. the interval var is what determines the speed
@michelleykim i noticed the bobbing is also choppy, but they are just regular keyframes so i'm not entirely sure what's going on. i'll look into it @meleongg i honestly am not sure how to fix this. the way we set up the backgrounds for each section is slicing it up and setting the aspect ratio of each slice. so for example 1440px (and 412 on mobile) looks fine, but on larger sizes it might be looking wack although i assumed they would all just grow the same way. any idea how it was done last year? (they also used aspect ratio strat) |
I kinda forgot what our verdict from yesterday was.. I feel like the buggy parts are prettyyy minor- should we just merge it to dev for now so I can send the preview to rest of the team to come up with the fix list? |