-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cudf._lib.utils usage in favor of pylibcudf #2082
Remove cudf._lib.utils usage in favor of pylibcudf #2082
Conversation
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Co-authored-by: Vyas Ramasubramani <[email protected]>
/ok to test |
What version of cudf is Morpheus on? I know that Morpheus usually lags cudf versions by a few months, so we should make sure that we are not merging this into a branch of Morpheus that won't have access to the newer cudf functionality yet either. |
Currently The unittests for Morpheus exercise this part of the code quite a bit albeit indirectly. |
/merge |
Description
In anticipation of this downstream cuDF PR removing some functionality in
cudf._lib.utils
rapidsai/cudf#17586, this PR replaces that usage with equivalent usage from the stablepylibcudf
By Submitting this PR I confirm: