Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cudf._lib.utils usage in favor of pylibcudf #2082

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

mroeschke
Copy link
Contributor

Description

In anticipation of this downstream cuDF PR removing some functionality in cudf._lib.utils rapidsai/cudf#17586, this PR replaces that usage with equivalent usage from the stable pylibcudf

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@mroeschke mroeschke requested a review from a team as a code owner December 13, 2024 23:40
Copy link

copy-pr-bot bot commented Dec 13, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@dagardner-nv
Copy link
Contributor

/ok to test

@dagardner-nv dagardner-nv self-assigned this Dec 13, 2024
@dagardner-nv dagardner-nv added non-breaking Non-breaking change improvement Improvement to existing functionality labels Dec 13, 2024
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dagardner-nv
Copy link
Contributor

/ok to test

@vyasr
Copy link

vyasr commented Dec 14, 2024

What version of cudf is Morpheus on? I know that Morpheus usually lags cudf versions by a few months, so we should make sure that we are not merging this into a branch of Morpheus that won't have access to the newer cudf functionality yet either.

@dagardner-nv
Copy link
Contributor

What version of cudf is Morpheus on? I know that Morpheus usually lags cudf versions by a few months, so we should make sure that we are not merging this into a branch of Morpheus that won't have access to the newer cudf functionality yet either.

Currently branch-25.02 is using cudf v24.10 we may update this prior to the release.

The unittests for Morpheus exercise this part of the code quite a bit albeit indirectly.

@dagardner-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 5e1116d into nv-morpheus:branch-25.02 Dec 16, 2024
11 checks passed
@mroeschke mroeschke deleted the rm/cudf_lib_utils branch December 16, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants