Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tensor_count property for ControlMessage #2078

Merged

Conversation

yczhang-nv
Copy link
Contributor

@yczhang-nv yczhang-nv commented Dec 5, 2024

Description

For ControlMessage, msg.tensors().count is a common pattern, calling msg.tensors() might require a bit more cost than we think. Add a tensor_count property to avoid the overhead.

Closes #1876

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@yczhang-nv yczhang-nv added non-breaking Non-breaking change improvement Improvement to existing functionality labels Dec 5, 2024
@yczhang-nv yczhang-nv self-assigned this Dec 5, 2024
@yczhang-nv yczhang-nv requested review from a team as code owners December 5, 2024 19:20
Copy link

copy-pr-bot bot commented Dec 5, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yczhang-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 32c982e into nv-morpheus:branch-25.02 Dec 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEA]: Add tensor_count property for ControlMessage
2 participants