Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for duplicate row IDs in log_parsing output #2031

Merged

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Oct 31, 2024

Description

  • Use the index of the incoming DF as the source of the doc field not the first column of the sequence_ids
  • Fix typeo in docstring for TableInfo::num_indices (unrelated)
  • Remove declaration for unimplemtned/unused function in python/morpheus/morpheus/_lib/include/morpheus/stages/deserialize.hpp (unrelated)

Closes #2029

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested review from a team as code owners October 31, 2024 22:30
@dagardner-nv dagardner-nv changed the title Fix for duplicate row id Fix for duplicate row IDs in log_parsing output Oct 31, 2024
@dagardner-nv dagardner-nv self-assigned this Oct 31, 2024
@dagardner-nv dagardner-nv changed the base branch from branch-25.02 to branch-24.10 October 31, 2024 22:31
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Oct 31, 2024
@dagardner-nv dagardner-nv marked this pull request as draft October 31, 2024 23:27
@dagardner-nv dagardner-nv marked this pull request as ready for review October 31, 2024 23:45
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 986abdb into nv-morpheus:branch-24.10 Nov 1, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG]: log_parsing output contains duplicate rows
2 participants