Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AttributeError: 'int' object has no attribute 'item' #1995

Merged
merged 13 commits into from
Oct 28, 2024
Merged

Fix AttributeError: 'int' object has no attribute 'item' #1995

merged 13 commits into from
Oct 28, 2024

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Oct 25, 2024 •
edited
Loading

Description

  • Fixes an issue where an int is being returned in the DFP rolling window stage, likely caused by the recent update to the version of pandas being used.
  • Update file paths to reflect the move of the dfp_duo_pipeline.py, dfp_azure_pipeline.py & dfp_integrated_training_batch_pipeline.py scripts
  • Document installing the missing dependencies needed for the DFP Grafana example

Closes #1994

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested review from a team as code owners October 25, 2024 21:36
@dagardner-nv dagardner-nv self-assigned this Oct 25, 2024
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Oct 25, 2024
@dagardner-nv dagardner-nv marked this pull request as draft October 25, 2024 21:39
@dagardner-nv dagardner-nv marked this pull request as ready for review October 25, 2024 22:43
mdemoret-nv
mdemoret-nv approved these changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AnuradhaKaruppiah
AnuradhaKaruppiah approved these changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@AnuradhaKaruppiah AnuradhaKaruppiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx for fixing up the paths.

examples/digital_fingerprinting/production/grafana/README.md Outdated Show resolved Hide resolved
@AnuradhaKaruppiah
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 4d84238 into nv-morpheus:branch-24.10 Oct 28, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

@AnuradhaKaruppiah AnuradhaKaruppiah AnuradhaKaruppiah approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dagardner-nv @AnuradhaKaruppiah @mdemoret-nv