Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add **kwargs back to NVFoundationLLMClient.generate_batch() and generate_batch_async() #1967

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Add **kwargs back to NVFoundationLLMClient.generate_batch() and generate_batch_async() #1967

merged 1 commit into from
Oct 22, 2024

Conversation

ashsong-nv
Copy link
Contributor

Description

This PR reverts the removal of the **kwargs argument from the NVFoundationLLMClient.generate_batch() and generate_batch_async() methods, which introduced a regression.

Closes #1961

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@ashsong-nv ashsong-nv requested a review from a team as a code owner October 22, 2024 16:21
@ashsong-nv ashsong-nv added bug Something isn't working non-breaking Non-breaking change labels Oct 22, 2024
dagardner-nv
dagardner-nv approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm assuming this is just putting the code back the way it was when we accepted **kwargs.

@ashsong-nv
Copy link
Contributor Author

LGTM, I'm assuming this is just putting the code back the way it was when we accepted **kwargs.

Yes that's correct.

@dagardner-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 2cfcc69 into nv-morpheus:branch-24.10 Oct 22, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagardner-nv dagardner-nv dagardner-nv approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashsong-nv @dagardner-nv