Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Morpheus docs update post compartmentalization #1964

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Morpheus docs update post compartmentalization #1964

merged 7 commits into from
Oct 22, 2024

Conversation

AnuradhaKaruppiah
Copy link
Contributor

@AnuradhaKaruppiah AnuradhaKaruppiah commented Oct 21, 2024 •
edited
Loading

  • Add a page for using the Morpheus conda packages
  • Add documentation for LLM and DFP stages APIs
  • [] Update example READMEs (if needed)

@AnuradhaKaruppiah AnuradhaKaruppiah added non-breaking Non-breaking change feature request New feature or request labels Oct 21, 2024
@AnuradhaKaruppiah AnuradhaKaruppiah self-assigned this Oct 21, 2024
@AnuradhaKaruppiah AnuradhaKaruppiah requested a review from a team as a code owner October 21, 2024 15:26
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 21, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@AnuradhaKaruppiah AnuradhaKaruppiah marked this pull request as draft October 21, 2024 15:26
@AnuradhaKaruppiah AnuradhaKaruppiah changed the title Morpheus docs update post compartmentalization Draft: Morpheus docs update post compartmentalization Oct 21, 2024
@AnuradhaKaruppiah AnuradhaKaruppiah force-pushed the docs-update branch 3 times, most recently from 9aed004 to 586c319 Compare October 21, 2024 16:34
@AnuradhaKaruppiah
Doc updates post compartmentalization
722b6e7 
Signed-off-by: Anuradha Karuppiah <[email protected]>
@AnuradhaKaruppiah AnuradhaKaruppiah force-pushed the docs-update branch 3 times, most recently from e50a8dc to ef610c8 Compare October 21, 2024 19:34
@AnuradhaKaruppiah AnuradhaKaruppiah marked this pull request as ready for review October 21, 2024 19:34
@AnuradhaKaruppiah AnuradhaKaruppiah requested a review from a team as a code owner October 21, 2024 19:34
@AnuradhaKaruppiah AnuradhaKaruppiah changed the title Draft: Morpheus docs update post compartmentalization Morpheus docs update post compartmentalization Oct 21, 2024
@AnuradhaKaruppiah
Copy link
Contributor Author

/ok to test

@AnuradhaKaruppiah
Copy link
Contributor Author

/ok to test

@AnuradhaKaruppiah
Add copyrights header
8b40cb2 
Signed-off-by: Anuradha Karuppiah <[email protected]>
@AnuradhaKaruppiah
Copy link
Contributor Author

/ok to test

1 similar comment
@AnuradhaKaruppiah
Copy link
Contributor Author

/ok to test

@AnuradhaKaruppiah
Copy link
Contributor Author

/ok to test

dagardner-nv
dagardner-nv approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things, overall looks good.

docs/source/conda_packages.md Outdated Show resolved Hide resolved
docs/source/conda_packages.md Outdated Show resolved Hide resolved
docs/source/conda_packages.md Outdated Show resolved Hide resolved
docs/source/conda_packages.md Outdated Show resolved Hide resolved
docs/source/conda_packages.md Outdated Show resolved Hide resolved
docs/source/conda_packages.md Show resolved Hide resolved
@AnuradhaKaruppiah
Fix vale syntax check failures
dba406c 
Signed-off-by: Anuradha Karuppiah <[email protected]>
@AnuradhaKaruppiah
Copy link
Contributor Author

/ok to test

@AnuradhaKaruppiah
Copy link
Contributor Author

Thx for the review and tips @dagardner-nv

@AnuradhaKaruppiah
Copy link
Contributor Author

/ok to test

@AnuradhaKaruppiah
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 4447923 into nv-morpheus:branch-24.10 Oct 22, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagardner-nv dagardner-nv dagardner-nv approved these changes

Assignees

@AnuradhaKaruppiah AnuradhaKaruppiah

Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnuradhaKaruppiah @dagardner-nv