Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devcontainer: replace VAULT_HOST with AWS_ROLE_ARN #1962

Merged
merged 3 commits into from
Oct 22, 2024
Merged

devcontainer: replace VAULT_HOST with AWS_ROLE_ARN #1962

merged 3 commits into from
Oct 22, 2024

Conversation

jjacobelli
Copy link
Contributor

Description

This PR is replacing the VAULT_HOST variable with AWS_ROLE_ARN. This is required to use the new token service to get AWS credentials.

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@jjacobelli jjacobelli added non-breaking Non-breaking change improvement Improvement to existing functionality labels Oct 21, 2024
@jjacobelli jjacobelli self-assigned this Oct 21, 2024
@jjacobelli jjacobelli marked this pull request as ready for review October 22, 2024 14:33
@jjacobelli jjacobelli requested a review from a team as a code owner October 22, 2024 14:33
@dagardner-nv
Copy link
Contributor

LGTM, merging branch-24.10 back in, just to make sure there's no conflicts with other changes.

@dagardner-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit a2949af into nv-morpheus:branch-24.10 Oct 22, 2024
10 of 11 checks passed
@jjacobelli jjacobelli deleted the devcontainers-vault branch October 22, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagardner-nv dagardner-nv dagardner-nv approved these changes

Assignees

@jjacobelli jjacobelli

Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjacobelli @dagardner-nv