Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a timeout to the queue.get call in HttpServerSourceStage to avoid spinlocking #1928

Merged
merged 5 commits into from
Oct 19, 2024
Merged

Provide a timeout to the queue.get call in HttpServerSourceStage to avoid spinlocking #1928

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d16b69f
Supply a timeout to queue.get to avoid spinlocking
dagardner-nv Oct 2, 2024
30adb91
Merge branch 'branch-24.10' into david-http-source-queue-get-timeout-…
dagardner-nv Oct 2, 2024
727a62b
Merge branch 'branch-24.10' into david-http-source-queue-get-timeout-…
dagardner-nv Oct 9, 2024
9db7da0
Merge branch 'branch-24.10' into david-http-source-queue-get-timeout-…
dagardner-nv Oct 9, 2024
f1d2a61
Merge branch 'branch-24.10' into david-http-source-queue-get-timeout-…
dagardner-nv Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/morpheus/morpheus/stages/input/http_server_source_stage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,8 @@ def _generate_frames(self, subscription: mrc.Subscription) -> typing.Iterator[Me
# shutdown since we already returned an OK response to the client.
df = None
try:
df = self._queue.get(block=False)
# Intentionally not using self._queue_timeout here since that value is rather high
df = self._queue.get(block=False, timeout=0.1)
self._queue_size -= 1
except queue.Empty:
if (not self._http_server.is_running() or self.is_stop_requested()
Expand Down
Loading