Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that pytest is able to run without optional dependencies #1927

Merged

Conversation

dagardner-nv
Copy link
Contributor

Description

  • Ensure it is possible to run pytest --run_slow with only the dev yaml installed.
  • Mark the tests in tests/utils/test_shared_process_pool.py as slow tests
  • Remove redundant import error messages.

Closes #1920

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Oct 2, 2024
@dagardner-nv dagardner-nv self-assigned this Oct 2, 2024
@dagardner-nv dagardner-nv requested review from a team as code owners October 2, 2024 17:56
…explicitly appear in the type-hint not as a lazy string
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit f43be04 into nv-morpheus:branch-24.10 Oct 4, 2024
13 checks passed
@dagardner-nv dagardner-nv deleted the david-optional-deps-1920 branch October 4, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG]: Running pytest fails due to missing optional dependencies
2 participants