Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DFP integrated training Azure pipeline #1894

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fix DFP integrated training Azure pipeline #1894

merged 1 commit into from
Sep 18, 2024

Conversation

yczhang-nv
Copy link
Contributor

@yczhang-nv yczhang-nv commented Sep 17, 2024 •
edited
Loading

Description

Fix DFP integrated training Azure pipeline, which indicates that user_id field is not attached to the ControlMessage.

Previously user_id is attached to UserMessageMeta, which is a subclass of MessageMeta that has an additional attribute. Now UserMessageMeta should be deprecated as all metadata can be attached directly to ControlMessage.

Closes #1893

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@yczhang-nv yczhang-nv added bug Something isn't working non-breaking Non-breaking change labels Sep 17, 2024
@yczhang-nv yczhang-nv self-assigned this Sep 17, 2024
@yczhang-nv yczhang-nv changed the title Fix broken DFP integrated training pipelines Fix broken DFP integrated training Azure pipelines Sep 17, 2024
@yczhang-nv yczhang-nv changed the title Fix broken DFP integrated training Azure pipelines Fix DFP integrated training Azure pipelines Sep 17, 2024
@yczhang-nv yczhang-nv changed the title Fix DFP integrated training Azure pipelines Fix DFP integrated training Azure pipeline Sep 17, 2024
@yczhang-nv yczhang-nv marked this pull request as ready for review September 17, 2024 18:49
@yczhang-nv yczhang-nv requested a review from a team as a code owner September 17, 2024 18:49
dagardner-nv
dagardner-nv approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 2c1bfdc into nv-morpheus:branch-24.10 Sep 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagardner-nv dagardner-nv dagardner-nv approved these changes

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@yczhang-nv yczhang-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: DFP integrated training Azure pipeline is broken
3 participants
@yczhang-nv @mdemoret-nv @dagardner-nv