Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Unregistered type : mrc::pymrc::coro::BoostFibersMainPyAwaitable error #1869

Merged
merged 7 commits into from
Aug 26, 2024
Merged

Fix Unregistered type : mrc::pymrc::coro::BoostFibersMainPyAwaitable error #1869

merged 7 commits into from
Aug 26, 2024

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Aug 26, 2024 •
edited
Loading

Description

  • Ensure BoostFibersMainPyAwaitable is registered by importing mrc.core.coro
  • Work-around for undefined symbol link error with c-ares
  • Fix paths to data files in validation scripts
  • Fix path to C++ files for CI checks
  • Replace usage of ie. to avoid documentation CI error

Closes #1868

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Aug 26, 2024
@dagardner-nv dagardner-nv self-assigned this Aug 26, 2024
@dagardner-nv dagardner-nv requested a review from a team as a code owner August 26, 2024 22:19
@dagardner-nv dagardner-nv requested a review from a team as a code owner August 26, 2024 22:22
@dagardner-nv dagardner-nv mentioned this pull request Aug 26, 2024
Closed
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 8235316 into nv-morpheus:branch-24.10 Aug 26, 2024
13 checks passed
@dagardner-nv dagardner-nv deleted the david-2410-unreg-type branch August 26, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnuradhaKaruppiah AnuradhaKaruppiah AnuradhaKaruppiah approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
2 participants
@dagardner-nv @AnuradhaKaruppiah