Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR_1736 "Always run the PR builder step even if others are cancelled" #1860

Merged

Conversation

AnuradhaKaruppiah
Copy link
Contributor

CIs are failing because of #1736 not playing well with rapidsai/shared-workflows#237

As a stopgap I am reverting the changes in #1736

@AnuradhaKaruppiah AnuradhaKaruppiah added bug Something isn't working non-breaking Non-breaking change labels Aug 23, 2024
@AnuradhaKaruppiah AnuradhaKaruppiah requested a review from a team as a code owner August 23, 2024 20:16
Copy link

copy-pr-bot bot commented Aug 23, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@AnuradhaKaruppiah
Copy link
Contributor Author

/ok to test

Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this

@AnuradhaKaruppiah
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5a83666 into nv-morpheus:branch-24.10 Aug 23, 2024
15 checks passed
dagardner-nv pushed a commit to dagardner-nv/Morpheus that referenced this pull request Aug 23, 2024
…celled" (nv-morpheus#1860)

CIs are failing because of nv-morpheus#1736 not playing well with  rapidsai/shared-workflows#237

As a stopgap I am reverting the changes in nv-morpheus#1736

Authors:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: nv-morpheus#1860
rapids-bot bot pushed a commit that referenced this pull request Aug 24, 2024
* Use pypdfium2 for PDF parsing
* Includes CI fix from PR #1860 

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)
  - Devin Robison (https://github.com/drobison00)
  - Bartley Richardson (https://github.com/BartleyR)

URL: #1861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants