Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved type-hints for stage and source decorators #1831

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Improved type-hints for stage and source decorators #1831

merged 1 commit into from
Aug 7, 2024

Conversation

dagardner-nv
Copy link
Contributor

Description

  • Improved type hints for both the input parameters and the return types

Closes #1812

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Aug 2, 2024
@dagardner-nv dagardner-nv self-assigned this Aug 2, 2024
@dagardner-nv dagardner-nv requested a review from a team as a code owner August 2, 2024 16:47
@dagardner-nv
Copy link
Contributor Author

stage_deco_type_hints

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 929531f into nv-morpheus:branch-24.10 Aug 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Fix incorrect typing for the @stage and @source decorators
2 participants
@dagardner-nv @mdemoret-nv