Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve rapids-dependency-file-generator warning #1735

Merged
merged 6 commits into from
Jun 25, 2024
Merged

resolve rapids-dependency-file-generator warning #1735

merged 6 commits into from
Jun 25, 2024

Conversation

jameslamb
Copy link
Contributor

@jameslamb jameslamb commented Jun 12, 2024

Description

Contributes to rapidsai/dependency-file-generator#89.

--file_key has been deprecated in rapids-dependency-file-generator for a few months, and I'm looking to fully remove it.

This PR proposes:

  • switching this project's uses from --file_key to --file-key
  • updating the version of rapids-dependency-file-generator used in pre-commit to its latest release

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@jameslamb jameslamb requested review from a team as code owners June 12, 2024 20:12
@cwharris
Copy link
Contributor

@jameslamb The following changes will need to be made before CI can pass: https://github.com/jameslamb/Morpheus/pull/1

Update CI Container to use newer DFG
@jameslamb
Copy link
Contributor Author

Merged, thanks!

@dagardner-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 7ec58a7 into nv-morpheus:branch-24.06 Jun 25, 2024
12 checks passed
@jameslamb jameslamb deleted the dfg-warning branch June 26, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants