Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests for NVFoundationLLMService and FaissVectorDbService #1714

Merged
merged 17 commits into from
Jun 12, 2024
Merged

Added tests for NVFoundationLLMService and FaissVectorDbService #1714

merged 17 commits into from
Jun 12, 2024

Conversation

acaklovic-nv
Copy link
Contributor

@acaklovic-nv acaklovic-nv commented May 20, 2024 •
edited
Loading

Description

  • Added tests for NVFoundation (test_nvfoundation_llm_client.py created)
  • Added tests for FAISS (test_faiss_vector_db_service.py created)
  • Changes to faiss_vdb_service.py (implemented more methods - insert, delete, count, create)
  • Changes to nvfoundation_llm_service.py (api key changes in NVFoundationLLMService)

Closes

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@acaklovic-nv acaklovic-nv added non-breaking Non-breaking change improvement Improvement to existing functionality labels May 20, 2024
@acaklovic-nv acaklovic-nv requested review from a team as code owners May 20, 2024 20:07
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented May 20, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mdemoret-nv mdemoret-nv changed the title Tests for NVFoundation, FAISS Added tests for NVFoundationLLMService and FaissVectorDbService May 20, 2024
@mdemoret-nv
Copy link
Contributor

/ok to test

@mdemoret-nv
Copy link
Contributor

/ok to test

@mdemoret-nv
Copy link
Contributor

/ok to test

@mdemoret-nv mdemoret-nv requested a review from a team as a code owner June 11, 2024 14:58
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@mdemoret-nv
Copy link
Contributor

/ok to test

@mdemoret-nv
Copy link
Contributor

/ok to test

@mdemoret-nv
Copy link
Contributor

/ok to test

@mdemoret-nv
Copy link
Contributor

/ok to test

@mdemoret-nv
Copy link
Contributor

/ok to test

@mdemoret-nv mdemoret-nv merged commit 9f3b8c1 into nv-morpheus:fea-agent-morpheus Jun 12, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acaklovic-nv @mdemoret-nv