Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused MLflow client arg from DFP inference implementations #1700

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ limitations under the License.
- [DFP Post Processing](#dfp-post-processing)
- [Serialize](#serialize)
- [Write to File](#write-to-file)
- [Running Example Modular DFP Pipelines](#running-example-modular-dfp-pipelines)
- [System requirements](#system-requirements)
- [Building the services](#building-the-services)
- [Downloading the example datasets](#downloading-the-example-datasets)
- [Run Morpheus pipeline](#run-morpheus-pipeline)
- [Output Fields](#output-fields)

## Introduction

Expand Down Expand Up @@ -522,7 +528,7 @@ pip install s3fs
python examples/digital_fingerprinting/fetch_example_data.py all
```

### Morpheus Pipeline
### Run Morpheus pipeline
From the `examples/digital_fingerprinting/production` dir, run:
```bash
docker compose run morpheus_pipeline bash
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def process_task(control_message: ControlMessage):
if (model_cache is None):
raise RuntimeError(f"Could not find model for user {user_id}")

loaded_model = model_cache.load_model(client)
loaded_model = model_cache.load_model()

# TODO(Devin): Recovery strategy should be more robust/configurable in practice
except Exception as exec_info:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def on_data(self, message: MultiDFPMessage) -> MultiDFPMessage:
if (model_cache is None):
raise RuntimeError(f"Could not find model for user {user_id}")

loaded_model = model_cache.load_model(self._client)
loaded_model = model_cache.load_model()

except Exception:
logger.exception("Error trying to get model", exc_info=True)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def last_used(self):
def last_checked(self):
return self._last_checked

def load_model(self, _) -> AutoEncoder:
def load_model(self) -> AutoEncoder:

now = datetime.now()

Expand Down
Loading