Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and unit test updates to OpenAI client #1698

Merged
merged 9 commits into from
May 21, 2024
Merged

Fixes and unit test updates to OpenAI client #1698

merged 9 commits into from
May 21, 2024

Conversation

efajardo-nv
Copy link
Contributor

@efajardo-nv efajardo-nv commented May 13, 2024 •
edited
Loading

Description

  • Update unit tests to handle recently added api_key and base_url parameters.
  • Ensure log directory exists for logging FileHandler.
  • Docstring update

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@efajardo-nv efajardo-nv added bug Something isn't working non-breaking Non-breaking change labels May 13, 2024
@efajardo-nv efajardo-nv self-assigned this May 13, 2024
@efajardo-nv efajardo-nv requested a review from a team as a code owner May 13, 2024 21:33
@efajardo-nv efajardo-nv marked this pull request as draft May 13, 2024 21:58
@efajardo-nv efajardo-nv marked this pull request as ready for review May 13, 2024 22:09
mdemoret-nv
mdemoret-nv requested changes May 14, 2024
View reviewed changes
morpheus/llm/services/openai_chat_service.py Outdated Show resolved Hide resolved
morpheus/llm/services/openai_chat_service.py Outdated Show resolved Hide resolved
tests/llm/services/test_openai_chat_client.py Outdated Show resolved Hide resolved
tests/llm/services/test_openai_chat_client.py Outdated Show resolved Hide resolved
tests/llm/services/test_openai_chat_client.py Show resolved Hide resolved
mdemoret-nv
mdemoret-nv approved these changes May 15, 2024
View reviewed changes
tests/llm/services/test_openai_chat_client.py Outdated Show resolved Hide resolved
tests/llm/services/conftest.py Outdated Show resolved Hide resolved
@mdemoret-nv mdemoret-nv merged commit d022466 into nv-morpheus:fea-agent-morpheus May 21, 2024
8 of 11 checks passed
@mdemoret-nv mdemoret-nv deleted the openai-client-updates branch May 22, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@efajardo-nv efajardo-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@efajardo-nv @mdemoret-nv