-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensuring consistent use of the export macro MORPHEUS_EXPORT
#1672
Merged
rapids-bot
merged 13 commits into
nv-morpheus:branch-24.06
from
aserGarcia:issue-1595-morpheus-export
May 9, 2024
Merged
Ensuring consistent use of the export macro MORPHEUS_EXPORT
#1672
rapids-bot
merged 13 commits into
nv-morpheus:branch-24.06
from
aserGarcia:issue-1595-morpheus-export
May 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yczhang-nv
approved these changes
May 1, 2024
mdemoret-nv
changed the title
#1595 MORPHEUS_EXPORT Consistency
Ensuring consistent use of the export macro May 1, 2024
MORPHEUS_EXPORT
/ok to test |
mdemoret-nv
requested changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment and we can merge. Thanks for the PR!
- All uses of
#include "morpheus/export.h"
should be converted to#include <morpheus/export.h>
when outside of themorpheus
directory. One was pointed out but there are a few places this needs to be fixed
mdemoret-nv
added
non-breaking
Non-breaking change
improvement
Improvement to existing functionality
labels
May 1, 2024
/ok to test |
mdemoret-nv
approved these changes
May 8, 2024
…tside of libmorpheus.so, avoids a compiler warning
/ok to test |
/merge |
rapids-bot
bot
merged commit May 9, 2024
9719d9f
into
nv-morpheus:branch-24.06
10 of 11 checks passed
@aserGarcia merged, thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes exporting symbols consistent across header files. The docs and examples for the developer_guide is also updated.
Closes #1595
By Submitting this PR I confirm: