Truncate strings exceeding max_length when inserting to Milvus #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avid-truncate-milvus-1650
…s_truncate helper
In insert_dataframe, perform pandas conversion as late as possible to perform as many operations in cudf as possible, also only pay the cost of converting the columns we need to pandas.
…long to MilvusVectorDBResourceService
mdemoret-nv
requested changes
Apr 24, 2024
…y_bytes per PR feedback [no ci]
…g to pandas, and call truncate_string_cols_by_bytes after converting to pandas [no ci]
…avid-truncate-milvus-1650 [no ci]
…t that is already slow
…s the only tensor
…ence_stage.py as a stage in the pipeline
mdemoret-nv
approved these changes
May 1, 2024
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
May 1, 2024
* Optionally strip HTML & XML tags embedded in RSS feeds Requires PR #1665 to be merged first Closes #1666 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1670
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
morpheus.io.utils,cudf_string_cols_exceed_max_bytesandtruncate_string_cols_by_bytestruncate_long_strings=TrueMilvusVectorDBResourceServicewill truncate allVARCHARfields according to the schema'smax_lengthtruncate_long_strings=Truein config forvdb_uploadpipelineknown_issues.mdCloses #1650
Closes #1651
By Submitting this PR I confirm: