[RELEASE] Morpheus v24.03.00 #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Executes the completion pipeline against mocked instances of nemollm and openai. * Mocked calls sleep for a set period of time, based upon observed times from my own machine. * Update completion pipeline example to optionally read country names from a file and optionally randomly sorting the order (These are changes I made to help with getting the timings, and don't really need to be merged). * Move the "inference" monitor to appear immediately after the inference stage. * Unrelated fix testing the results of `tests/llm/test_agents_simple_pipe.py::test_agents_simple_pipe_integration_openai` * Add CSV file containing the names of UN member nations ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1414
Fix auto merger conflict when merging `branch-23.11` into `branch-24.03` (#1426)
- Fix modular DFP benchmark and examples after `DFPArgParser`updates from PR #1245 - Shorten `load` file paths in example control messages - Doc fixes Fixes #1431 Fixes #1432 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Eli Fajardo (https://github.com/efajardo-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1429
* Adds entry to `docs/source/extra_info/troubleshooting.md` regarding incompatible MLflow models. Closes #1409 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Pete MacKinnon (https://github.com/pdmack) - Michael Demoret (https://github.com/mdemoret-nv) URL: #1434
* Adds a benchmark for the vdb_upload & RAG stand-alone pipelines. * The vdb_upload benchmark mocks the HTTP requests performed by the RSS source and webscraper stages. * Update benchmark instructions in `tests/benchmarks/README.md` ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1421
* Add a test for the LLM agents pipeline that doesn't communicate with OpenAI or SerpAPI. * Add benchmark for LLM agents pipeline. Includes changes from PR #1421 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1424
Requested updates on behalf of Michael Boone. Authors: - Devin Robison (https://github.com/drobison00) - https://github.com/HesAnEasyCoder Approvers: - https://github.com/raykallen - https://github.com/shawn-davis URL: #1437
Requested updates on behalf of Michael Boone. Authors: - Devin Robison (https://github.com/drobison00) - https://github.com/HesAnEasyCoder Approvers: - https://github.com/raykallen URL: #1438
Requested updates on behalf of Michael Boone Authors: - Devin Robison (https://github.com/drobison00) - https://github.com/HesAnEasyCoder Approvers: - https://github.com/raykallen URL: #1439
This fixes three issues: 1. Camouflage not starting up within the 10s timeout when the CI system is under high load. This was fixed by simply increasing the timeout to 30s. 2. Camouflage startup errors (command not fount, out of memory etc...) not being reported since stdout/stderr were being sent to `/dev/null`. This was fixed by redirecting stdout/stderr to a file, and displaying the content on failure. This is a work-around for not being able to control the log level of camouflage's console logger: testinggospels/camouflage#244 We can't redirect stdout/stderr to a PIPE since on successful startup the PIPE would fill and block camouflage. Closes #1417 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1436
* Adds a `get-pr-info` job at the head of the pipeline which examines the labels on the PR. * If the PR contains the `skip-ci` label, the rest of the jobs in the CI pipeline are skipped. * This avoids the requirement to include `[no ci]` in commit comments. * After the label is removed CI will execute on the next push. Closes #1183 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1444
* Rather than checking keys in the `globals()` dictionary, check if the exception is not-None * Remove `morpheus/utils/verify_dependencies.py` Closes #1435 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1443
* Allows manually seeding random number generators from the CLI via either `--manual_seed` or setting the `MORPHEUS_MANUAL_SEED` environment variable. * Makes testing example CLI pipelines easier. Closes #1211 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1445
Adds rapids-dependency-file-generator pre-commit checks for local and CI, and updates scripts to use the generated environment files. Contributes to #1389 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Christopher Harris (https://github.com/cwharris) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1441
…1440) Removes the deprecated python settings in favor of the options recommended in https://github.com/microsoft/vscode-python/wiki/Migration-to-Python-Tools-Extensions Authors: - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Devin Robison (https://github.com/drobison00) URL: #1440
* Update `morpheus/modules/payload_batcher.py` to avoid sending a single-element-list to `cudf.DataFrame.groupby`, this avoids a warning about an upcoming behavior change. * Ignore warnings emitted from merlin/nvt regarding tensorflow not being installed * Ignore warnings about `distutils` being deprecated while running tests. * Mark `tests/common/test_http_server.py` as a slow test (takes ~1m) * Update `tests/modules/test_payload_batcher.py` to expect/filter a warning ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Devin Robison (https://github.com/drobison00) - Michael Demoret (https://github.com/mdemoret-nv) URL: #1447
+ Replace `GPUtil` with `pynvml` to collect GPU stats for benchmark reports. + Remove `GPUtil` from dependency yaml's. `pynvml` is already installed via `nvtabular`. Closes #1446 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Eli Fajardo (https://github.com/efajardo-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1451
* Add `needs_logits` & `inout_mapping` a constructor arguments to `TritonInferenceStage`. * Consolidate triton inference worker impls into a single `TritonInferenceWorker` class * For compatibility the `needs_logits` & `inout_mapping` arguments default to default values inferred by the pipeline mode. * Refactor custom triton inference stage from `examples/log_parsing` example as a subclass of `TritonInferenceStage` removing several lines of redundant code. * `examples/log_parsing` example now works in C++ mode * Add the ability to subclass a stage registered with the CLI, and register the sublcass with a new CLI name. * Add the ability to parse dictionary types with click. * Remove `inf-triton` from the AE mode in the CLI * Misc linting/formatting pylint suggestions Closes #1378 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Devin Robison (https://github.com/drobison00) - Michael Demoret (https://github.com/mdemoret-nv) URL: #1402
- Fixes bug in logger where it was looking for `json` instead of `.json` when passing JSON config file. Fixes #1470 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Eli Fajardo (https://github.com/efajardo-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1471
- Add notebook fixes from @tzemicheal - Migrate remaining pandas code to cudf Closes #1265 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Eli Fajardo (https://github.com/efajardo-nv) Approvers: - Tad ZeMicheal (https://github.com/tzemicheal) URL: #1450
This PR addresses an issue in the dfencoder model related to its convergence behavior. Previously, the model exhibited difficulty in converging when trained exclusively with numerical features. This PR fixes the way different loss types are combined in the model's loss function to ensure that backpropagation works correctly. Note: This may alter the exact values resulting from calling `fit()` on the model. Before, categorical features were weighted much higher than binary or numerical categories (all numerical features shared a combined weight of 1, all binaries features shared a combined weight of 1, and each categorical feature had a weight of 1). Now all features are weighted equally which may impact the trained weights. Closes #1455 Authors: - https://github.com/hsin-c - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1460
* Creates a new `BoundaryStageMixin` class * Allowing `LinearBoundaryEgressStage` and `LinearBoundaryIngressStage` to share a common class and be distinguished from other stages Closes #638 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Devin Robison (https://github.com/drobison00) - Michael Demoret (https://github.com/mdemoret-nv) URL: #1473
* Allows users to create C++ stages/messages without a source code checkout of morpheus. * Explicitly install cpython extensions as a part of the python install. * Remove usage of `YAPF_EXCLUDE_FLAGS` work-around for an old yapf bug which has been fixed in our current version. * Update C++ developer guide examples to optionally build independently of morpheus. * Install versioneer as a conda package, remove in-repo copy of versioneer.py Closes #331 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) - Christopher Harris (https://github.com/cwharris) URL: #1448
Addressed redundant feed fetches in the RSS Controller when parsing manually with BeautifulSoup and cache is enabled. Closes #1419 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Bhargav Suryadevara (https://github.com/bsuryadevara) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1442
* Update examples to use package relative paths where possible allowing users of the Morpheus conda package to run examples. * Install `pyarrow-hotfix` via conda rather than pip * Ensure `pyarrow-hotfix` is installed during conda build enabling stubs to be generated. * Fix version restriction for sqlalchemy in `meta.yaml` * Fix type-o in `dependencies.yaml` causing duplicate entries for the `click` package. * Add examples target to `dependencies.yaml`. * Specify a version for sysroot_linux-64, prevents older kernel headers from being installed causing glibc link errors. * Update `docker/build_conda_packages.sh` to create `.conda-bld` dir if it doesn't already exist Closes #1461 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1462
- Update environment yaml paths to point to `conda/environments` instead of `morpheus/conda/environments`. - Update `docker/Dockerfile` to copy all yaml files from `conda/environments` to runtime image. - Fix broken environment yaml path in DFP Dockerfile to use above examples yaml. - Remove DFP `conda_env.yml` which is out of date and no longer used. DFP dependencies have already been moved to the examples yaml with updated versions. Closes #1554 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Eli Fajardo (https://github.com/efajardo-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1551
Upgrade DOCA source stage API from 2.2 to 2.5 + code restyle ```[tasklist] ### Waiting on - [ ] nv-morpheus/MRC#433 - [ ] #1468 ``` Authors: - eago (https://github.com/e-ago) - https://github.com/eagonv - Christopher Harris (https://github.com/cwharris) Approvers: - Christopher Harris (https://github.com/cwharris) URL: #1475
- Update `mlflow_writer_options` in DFP config generator to use Python 3.10 (from 3.8) for model's conda environment. - Update base image of MLflow container to Python 3.10. Closes #1565 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Eli Fajardo (https://github.com/efajardo-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1572
…RI (#1578) - Small update to handle MLflow `search_registered_models` results using file URI. Closes #1574 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Eli Fajardo (https://github.com/efajardo-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1578
…w override (#1580) - Update `file_batcher`module to use documented module config key `iso_date_regex_pattern` instead of `batch_iso_date_regex_pattern`. - Allow override of `iso_date_regex_pattern` with control message. - Add tests for `file_batcher` module Closes #1576 Closes #1577 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Eli Fajardo (https://github.com/efajardo-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1580
This removes the `defaults` channel from `dependencies.yml` to use only `conda-forge` ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #1584
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…from errors (#1548) Factor out the Triton inference logic in the Triton inference stage to a client class which can be swapped out for a fake/test client. Keep retry logic in the Stage and test using a fake/test client. Closes #1510 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Christopher Harris (https://github.com/cwharris) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1548
* Fixes an issue where the `--start_time` flag was being ignored * Prior to nv-morpheus/MRC#451 the `datetime` objects being stored in the config were being serialized to json null, after that change an exception was raised. Closes #1590 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1592
Modified the Dockerfile if DOCA is enabled to install with apt DOCA debian packages from public repo instead of the internal repo ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - eago (https://github.com/e-ago) - https://github.com/eagonv - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1588
* Set new minimums to Volta (compute 7), cuda-12.1 * Remove minimum driver version, and instead just document our cuda version. Closes #1464 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1594
…` `AddScoreStageBase` (#1573) Support `ControlMessage` as an input type for `PreProcessNLPStage` `PreProcessFILStage` `AddScoreStageBase` ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Yuchen Zhang (https://github.com/yuchenz427) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1573
…anch-* and main to succeed
This PR update `nlohmann_json` to 3.11 to match MRC. ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Michael Demoret (https://github.com/mdemoret-nv) Approvers: None URL: #1596
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
mdemoret-nv
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❄️ Code freeze for
branch-24.03andv24.03releaseWhat does this mean?
Only critical/hotfix level issues should be merged into
branch-24.03until release (merging of this PR).All other development PRs should be retargeted towards the next release branch:
branch-24.06.What is the purpose of this PR?
branch-24.03intomainfor the release