-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge fea-sherlock feature branch into branch-23.11 #1359
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine-runnable Improving the `CoroutineRunnable` class to use schedulers and support multiple in-flight messages
…avid-fea-sherlock-restructure
…ntext and InputMap constructors
Co-authored-by: Michael Demoret <[email protected]>
…-nv/Morpheus into david-fea-sherlock-restructure
…avid-fea-sherlock-restructure
drobison00
added
improvement
Improvement to existing functionality
DO NOT MERGE
PR should not be merged; see PR for details
sherlock
Issues/PRs related to Sherlock workflows and components
labels
Nov 13, 2023
…avid-fea-sherlock-end-to-end-vdb-upload
Updated agents pipeline README.md Closes #1307 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Bhargav Suryadevara (https://github.com/bsuryadevara) Approvers: - Devin Robison (https://github.com/drobison00) URL: #1352
Allows injecting an optional cache path to the WebScraperStage. If `cache_path` is not None, it uses the path as the path for the response caching system's sqllite database. If `cache_path` is None, the response caching system is bypassed. Closes #1355 Authors: - Christopher Harris (https://github.com/cwharris) Approvers: - Devin Robison (https://github.com/drobison00) URL: #1358
Commits some models to LFS which were accidentally committed as source code. Authors: - Christopher Harris (https://github.com/cwharris) - Devin Robison (https://github.com/drobison00) Approvers: - Devin Robison (https://github.com/drobison00) - Bhargav Suryadevara (https://github.com/bsuryadevara) URL: #1343
…end-vdb-upload End to end test for vdb upload example
Added agents simple pipeline test ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Bhargav Suryadevara (https://github.com/bsuryadevara) Approvers: - Devin Robison (https://github.com/drobison00) URL: #1363
Add missing milvus mark for two tests which require milvus
…o stopping the server
… merge back into 23.11 (#1365) Authors: - Devin Robison (https://github.com/drobison00) - Bhargav Suryadevara (https://github.com/bsuryadevara) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #1365
…avid-fea-sherlock-http-test-ci-1370
…st-ci-1370 Draft: fix for test_simple_request
Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) - Bhargav Suryadevara (https://github.com/bsuryadevara) - Devin Robison (https://github.com/drobison00) - Eli Fajardo (https://github.com/efajardo-nv) Approvers: - Devin Robison (https://github.com/drobison00) URL: #1374
Made the `enable_cache` accessible as a parameter ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Bhargav Suryadevara (https://github.com/bsuryadevara) Approvers: - Devin Robison (https://github.com/drobison00) URL: #1376
mdemoret-nv
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to get merged into branch-23.11
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
Improvement to existing functionality
non-breaking
Non-breaking change
sherlock
Issues/PRs related to Sherlock workflows and components
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge fea-sherlock feature branch into branch-23.11