-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add end-to-end tests for completion and stand-alone rag pipelines #1353
Merged
dagardner-nv
merged 20 commits into
nv-morpheus:fea-sherlock
from
dagardner-nv:david-fea-sherlock-end-to-end
Nov 13, 2023
Merged
Add end-to-end tests for completion and stand-alone rag pipelines #1353
dagardner-nv
merged 20 commits into
nv-morpheus:fea-sherlock
from
dagardner-nv:david-fea-sherlock-end-to-end
Nov 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to-use on the service level
…to-use on the service level
dagardner-nv
added
non-breaking
Non-breaking change
improvement
Improvement to existing functionality
sherlock
Issues/PRs related to Sherlock workflows and components
labels
Nov 8, 2023
…avid-fea-sherlock-end-to-end
…f rows in those messages [no ci]
…avid-fea-sherlock-end-to-end
… large number of records [no ci]
…the pipeline mode, remove redundant punctuation from prompt [no ci]
…avid-fea-sherlock-end-to-end
dagardner-nv
changed the title
Draft: Create end to end tests for the LLM example pipelines
Add end-to-end tests for completion and stand-alone rag pipelines
Nov 9, 2023
drobison00
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
Improvement to existing functionality
non-breaking
Non-breaking change
sherlock
Issues/PRs related to Sherlock workflows and components
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--embedding_size
to stand-alone rag pipeline, removing previously hard-coded valuestop_after
argument in RSS source stage.tests/llm/services/conftest.py
totests/llm/conftest.py
examples/llm/rag/persistant_pipeline.py
, due toSplitStage
not being updated.By Submitting this PR I confirm: