Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end-to-end tests for completion and stand-alone rag pipelines #1353

Merged

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Nov 8, 2023

Description

  • Add end-to-end tests for completion and stand-alone rag pipelines
  • Optionally support openai as a backend for the rag pipeline
  • Add --embedding_size to stand-alone rag pipeline, removing previously hard-coded value
  • Fix evaluation of stop_after argument in RSS source stage.
  • Relocate some fixtures from tests/llm/services/conftest.py to tests/llm/conftest.py
  • Currently checks are failing for examples/llm/rag/persistant_pipeline.py, due to SplitStage not being updated.

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested review from a team as code owners November 8, 2023 17:37
Copy link

copy-pr-bot bot commented Nov 8, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@dagardner-nv dagardner-nv changed the base branch from branch-23.11 to fea-sherlock November 8, 2023 17:37
@dagardner-nv dagardner-nv marked this pull request as draft November 8, 2023 17:37
@dagardner-nv dagardner-nv self-assigned this Nov 8, 2023
@dagardner-nv dagardner-nv added non-breaking Non-breaking change improvement Improvement to existing functionality sherlock Issues/PRs related to Sherlock workflows and components labels Nov 8, 2023
@dagardner-nv dagardner-nv changed the title Draft: Create end to end tests for the LLM example pipelines Add end-to-end tests for completion and stand-alone rag pipelines Nov 9, 2023
@dagardner-nv dagardner-nv marked this pull request as ready for review November 9, 2023 18:34
@dagardner-nv dagardner-nv merged commit 557dbd6 into nv-morpheus:fea-sherlock Nov 13, 2023
9 of 10 checks passed
@dagardner-nv dagardner-nv deleted the david-fea-sherlock-end-to-end branch November 13, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change sherlock Issues/PRs related to Sherlock workflows and components
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants