Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Milvus Tests and Exposed release_resource API #1348

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Updated Milvus Tests and Exposed release_resource API #1348

merged 3 commits into from
Nov 8, 2023

Conversation

bsuryadevara
Copy link
Contributor

@bsuryadevara bsuryadevara commented Nov 7, 2023 •
edited
Loading

Description

  • Updated tests to mitigate bug from milvus==2.3.2
  • Exposed release_resource API
  • Removed tests that verifies collection_lock mechanism

Closes #1345

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@bsuryadevara bsuryadevara added the bug Something isn't working label Nov 7, 2023
@bsuryadevara bsuryadevara added this to the 23.11 - Sherlock milestone Nov 7, 2023
@bsuryadevara bsuryadevara self-assigned this Nov 7, 2023
@bsuryadevara bsuryadevara requested a review from a team as a code owner November 7, 2023 16:29
@bsuryadevara bsuryadevara added non-breaking Non-breaking change sherlock Issues/PRs related to Sherlock workflows and components labels Nov 7, 2023
@bsuryadevara bsuryadevara linked an issue Nov 7, 2023 that may be closed by this pull request
[BUG]: Milvus 2.3.2 is breaking milvus_vector_db_service tests #1345
Closed
2 tasks
@bsuryadevara bsuryadevara changed the title Updated Tests and Exposed release_resource API Updated Milvus Tests and Exposed release_resource API Nov 7, 2023
cwharris
cwharris requested changes Nov 7, 2023
View reviewed changes
morpheus/service/vdb/milvus_vector_db_service.py Outdated Show resolved Hide resolved
tests/test_milvus_vector_db_service.py Show resolved Hide resolved
tests/test_milvus_vector_db_service.py Show resolved Hide resolved
@bsuryadevara bsuryadevara requested a review from cwharris November 8, 2023 19:48
@bsuryadevara
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 895d915 into nv-morpheus:fea-sherlock Nov 8, 2023
5 of 6 checks passed
@cwharris cwharris mentioned this pull request Nov 9, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwharris cwharris cwharris approved these changes

Assignees

@bsuryadevara bsuryadevara

Labels
bug Something isn't working non-breaking Non-breaking change sherlock Issues/PRs related to Sherlock workflows and components
Projects
Morpheus Boards
Archived in project
Milestone
23.11 - Sherlock
Development

Successfully merging this pull request may close these issues.

[BUG]: Milvus 2.3.2 is breaking milvus_vector_db_service tests
2 participants
@bsuryadevara @cwharris