Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to MilvusVectorDB Service #1294

Merged
merged 23 commits into from
Oct 30, 2023
Merged

Improvements to MilvusVectorDB Service #1294

merged 23 commits into from
Oct 30, 2023

Conversation

bsuryadevara
Copy link
Contributor

Description

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@bsuryadevara bsuryadevara added non-breaking Non-breaking change improvement Improvement to existing functionality sherlock Issues/PRs related to Sherlock workflows and components labels Oct 20, 2023
@bsuryadevara bsuryadevara self-assigned this Oct 20, 2023
@bsuryadevara bsuryadevara linked an issue Oct 20, 2023 that may be closed by this pull request
[FEA]: Improve the VectorDBService and WriteToVectorDBStage to handle similarity search #1272
Closed
2 tasks
@bsuryadevara bsuryadevara added this to the 23.11 - Sherlock milestone Oct 20, 2023
@bsuryadevara bsuryadevara marked this pull request as ready for review October 20, 2023 05:00
@bsuryadevara bsuryadevara requested a review from a team as a code owner October 20, 2023 05:00
@bsuryadevara bsuryadevara marked this pull request as draft October 20, 2023 15:40
@bsuryadevara bsuryadevara marked this pull request as ready for review October 20, 2023 15:49
@mdemoret-nv mdemoret-nv mentioned this pull request Oct 22, 2023
Closed
28 tasks
drobison00
drobison00 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@drobison00 drobison00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved; one or two small comments.

morpheus/service/vdb/milvus_vector_db_service.py Show resolved Hide resolved
morpheus/service/vdb/milvus_vector_db_service.py Show resolved Hide resolved
morpheus/service/vdb/milvus_vector_db_service.py Show resolved Hide resolved
drobison00
drobison00 requested changes Oct 24, 2023
View reviewed changes
morpheus/controllers/rss_controller.py Show resolved Hide resolved
morpheus/controllers/rss_controller.py Outdated Show resolved Hide resolved
tests/controllers/test_rss_controller.py Outdated Show resolved Hide resolved
drobison00
drobison00 requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@drobison00 drobison00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments and some change requests related to avoiding testing internal class behavior.

morpheus/controllers/rss_controller.py Outdated Show resolved Hide resolved
morpheus/controllers/rss_controller.py Outdated Show resolved Hide resolved
tests/controllers/test_rss_controller.py Outdated Show resolved Hide resolved
tests/controllers/test_rss_controller.py Outdated Show resolved Hide resolved
tests/controllers/test_rss_controller.py Outdated Show resolved Hide resolved
tests/test_rss_source_stage_pipe.py Show resolved Hide resolved
tests/test_rss_source_stage_pipe.py Outdated Show resolved Hide resolved
drobison00
drobison00 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@drobison00 drobison00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsuryadevara
Copy link
Contributor Author

\merge

@bsuryadevara
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 12c0b80 into nv-morpheus:fea-sherlock Oct 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drobison00 drobison00 drobison00 approved these changes

Assignees

@bsuryadevara bsuryadevara

Labels
improvement Improvement to existing functionality non-breaking Non-breaking change sherlock Issues/PRs related to Sherlock workflows and components
Projects
Morpheus Boards
Archived in project
Milestone
23.11 - Sherlock
Development

Successfully merging this pull request may close these issues.

[FEA]: Improve the VectorDBService and WriteToVectorDBStage to handle similarity search
2 participants
@bsuryadevara @drobison00