PyCoro binding code test #1286
Closed
PyCoro binding code test #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwharris
added
non-breaking
mdemoret-nv
requested changes
Oct 18, 2023
There was a problem hiding this comment.
This is a great start but I would like to see more edge cases. The issue has the following listed:
- Throwing exceptions from C++
- Throwing exceptions from Python
- Cancelling coroutines from python
- Abnormal shutdown of the loop
- Nested layers of python -> C++ -> python -> C++ coroutines
I only see one of those exercised here
|
@cwharris Can you get the check stage to pass and then we can merge? |
mdemoret-nv
approved these changes
Oct 19, 2023
rapids-bot bot
pushed a commit
to nv-morpheus/MRC
that referenced
this pull request
Oct 25, 2023
Moves pycoro from Morpheus to MRC and incorperates tests from nv-morpheus/Morpheus#1286 Closes nv-morpheus/Morpheus#1268 Authors: - Christopher Harris (https://github.com/cwharris) Approvers: - Devin Robison (https://github.com/drobison00) URL: #409
|
Closing in favor of nv-morpheus/MRC#409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests the python/cpp coroutine binding code (pycoro) to ensure recursive/nested and parallel python and c++ calls can be interleaved without issue, that Python/C++ -mixed tasks can be cancelled from Python, and that exceptions throw from both C++ and Python can be caught in Python. Also allows
PyTaskToCppAwaitableto be constructed with a raw python coroutine as opposed to only asyncio tasks.Closes #1268
By Submitting this PR I confirm: