Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Running pytest fails due to missing optional dependencies #1920

Closed
2 tasks done
dagardner-nv opened this issue Oct 1, 2024 · 0 comments · Fixed by #1927
Closed
2 tasks done

[BUG]: Running pytest fails due to missing optional dependencies #1920

dagardner-nv opened this issue Oct 1, 2024 · 0 comments · Fixed by #1927
Assignees
@dagardner-nv
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

Version

24.10

Which installation method(s) does this occur on?

Source

Describe the bug.

It should be possible to run the pytest command without the --fail_missing flag should skip all tests which require an optional dependency not present in the dev yaml.

Minimum reproducible example

No response

Relevant log output

Click here to see error details
[Paste the error here, it will be hidden by default]

Full env printout

Click here to see environment details
[Paste the results of print_env.sh here, it will be hidden by default]

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Oct 1, 2024
@dagardner-nv dagardner-nv self-assigned this Oct 1, 2024
@dagardner-nv dagardner-nv moved this from Todo to In Progress in Morpheus Boards Oct 1, 2024
@dagardner-nv dagardner-nv mentioned this issue Oct 2, 2024
Merged
@morpheus-bot-test morpheus-bot-test bot moved this from In Progress to Review - Ready for Review in Morpheus Boards Oct 2, 2024
rapids-bot bot pushed a commit that referenced this issue Oct 4, 2024
@dagardner-nv
Ensure that pytest is able to run without optional dependencies (#1927
f43be04 
)

* Ensure it is possible to run `pytest --run_slow` with only the dev yaml installed.
* Mark the tests in `tests/utils/test_shared_process_pool.py` as slow tests
* Remove redundant import error messages.

Closes [#1920](#1920)

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: #1927
@rapids-bot rapids-bot bot closed this as completed in #1927 Oct 4, 2024
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure that pytest is able to run without optional dependencies dagardner-nv/Morpheus
1 participant
@dagardner-nv