Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Convert all uses of #pragma GCC visibility push(default) to use MORPHEUS_EXPORT #1595

Closed
2 of 6 tasks
mdemoret-nv opened this issue Apr 7, 2024 · 2 comments · Fixed by #1672
Closed
2 of 6 tasks
Labels
feature request New feature or request good first issue Good for newcomers

Comments

@mdemoret-nv
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Low (would be nice)

Please provide a clear description of problem this feature solves

We have mixed usage of #pragma GCC visibility push(default) and MORPHEUS_EXPORT which is inconsistent. Since using #pragma GCC is not part of the C++ standard, it would be better to use MORPHEUS_EXPORT to allow other compilers to be used in the future. Using MORPHEUS_EXPORT is more explicit and works more consistently (in my experience).

Describe your ideal solution

The following should be completed to close this issue:

Completion Criteria

  • Remove all uses of #pragma GCC visibility push(default) and #pragma GCC visibility pop
  • Determine rules for which classes/functions/structs/etc should be exported
  • Add these rules to the developer docs
  • Using the above rules, add MORPHEUS_EXPORT to the classes/functions/structs/etc which should be exported

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@mdemoret-nv mdemoret-nv added good first issue Good for newcomers feature request New feature or request labels Apr 7, 2024
@aserGarcia
Copy link
Contributor

Looking to work on this as a first issue. I take it no test is required for this one as it's not listed in the completion criteria?

@aserGarcia
Copy link
Contributor

aserGarcia commented Apr 29, 2024

I have a working solution but I do not have permission to push the branch
remote: Permission to nv-morpheus/Morpheus.git denied to aserGarcia.

Disregard.

rapids-bot bot pushed a commit that referenced this issue May 9, 2024
This PR makes exporting symbols consistent across header files. The docs and examples for the developer_guide is also updated.

  
Closes #1595 

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Aser Garcia (https://github.com/aserGarcia)
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Yuchen Zhang (https://github.com/yuchenz427)
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1672
@rapids-bot rapids-bot bot closed this as completed in #1672 May 9, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Morpheus Boards May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants