Skip to content

Commit

Permalink
Fix mis-leading deserialize stage comments (#2009)
Browse files Browse the repository at this point in the history
* The deserialize stage no longer actually deserializes, but instead chunks incoming `MessageMeta` objects and converts to `ControlMessage`

Closes #2007

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Yuchen Zhang (https://github.com/yczhang-nv)

URL: #2009
  • Loading branch information
dagardner-nv authored Oct 29, 2024
1 parent 0e46093 commit 113b235
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion examples/abp_nvsmi_detection/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ morpheus --log_level=DEBUG \
pipeline-fil --columns_file=data/columns_fil.txt \
`# 1st Stage: Read from file` \
from-file --filename=examples/data/nvsmi.jsonlines \
`# 2nd Stage: Deserialize from JSON strings to objects` \
`# 2nd Stage: Deserialize batch DataFrame into ControlMessages` \
deserialize \
`# 3rd Stage: Preprocessing converts the input data into BERT tokens` \
preprocess \
Expand Down
2 changes: 1 addition & 1 deletion examples/nlp_si_detection/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ morpheus --log_level=DEBUG \
pipeline-nlp --model_seq_length=256 \
`# 1st Stage: Read from file` \
from-file --filename=examples/data/pcap_dump.jsonlines \
`# 2nd Stage: Deserialize from JSON strings to objects` \
`# 2nd Stage: Deserialize batch DataFrame into ControlMessages` \
deserialize \
`# 3rd Stage: Preprocessing converts the input data into BERT tokens` \
preprocess --vocab_hash_file=data/bert-base-uncased-hash.txt --do_lower_case=True --truncation=True \
Expand Down
2 changes: 1 addition & 1 deletion examples/root_cause_analysis/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ run --num_threads=8 --edge_buffer_size=4 --pipeline_batch_size=1024 --model_max_
pipeline-nlp --model_seq_length=128 --label=not_root_cause --label=is_root_cause \
`# 1st Stage: Read from file` \
from-file --filename=${MORPHEUS_ROOT}/models/datasets/validation-data/root-cause-validation-data-input.jsonlines \
`# 2nd Stage: Deserialize from JSON strings to objects` \
`# 2nd Stage: Deserialize batch DataFrame into ControlMessages` \
deserialize \
`# 3rd Stage: Preprocessing converts the input data into BERT tokens` \
preprocess --column=log --vocab_hash_file=./data/bert-base-uncased-hash.txt --truncation=True --do_lower_case=True --add_special_tokens=False \
Expand Down

0 comments on commit 113b235

Please sign in to comment.