Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where Python sources can deadlock when the subscriber is unsubscribed #495

Closed
wants to merge 25 commits into from

Move the construction of PyIteratorIterator into the try block as the…

8b4c59c
Select commit
Loading
Failed to load commit list.
Closed

Fix issue where Python sources can deadlock when the subscriber is unsubscribed #495

Move the construction of PyIteratorIterator into the try block as the…
8b4c59c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Aug 29, 2024 in 1s

89.79% of diff hit (target 74.06%)

View this Pull Request on Codecov

89.79% of diff hit (target 74.06%)

Annotations

Check warning on line 73 in python/mrc/_pymrc/src/segment.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/mrc/_pymrc/src/segment.cpp#L72-L73 

Added lines #L72 - L73 were not covered by tests

Check warning on line 80 in python/mrc/_pymrc/src/segment.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/mrc/_pymrc/src/segment.cpp#L79-L80 

Added lines #L79 - L80 were not covered by tests

Check warning on line 100 in python/mrc/_pymrc/src/segment.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/mrc/_pymrc/src/segment.cpp#L99-L100 

Added lines #L99 - L100 were not covered by tests

Check warning on line 103 in python/mrc/_pymrc/src/segment.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/mrc/_pymrc/src/segment.cpp#L103 

Added line #L103 was not covered by tests

Check warning on line 105 in python/mrc/_pymrc/src/segment.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/mrc/_pymrc/src/segment.cpp#L105 

Added line #L105 was not covered by tests

Check warning on line 312 in python/mrc/_pymrc/src/segment.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/mrc/_pymrc/src/segment.cpp#L312 

Added line #L312 was not covered by tests

Check warning on line 378 in python/mrc/_pymrc/src/segment.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/mrc/_pymrc/src/segment.cpp#L378 

Added line #L378 was not covered by tests
View more details on Codecov