Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop a python source once the subscriber is no longer subscribed #493

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Aug 28, 2024

Description

  • When a Python generator source yields a value, and the subscriber is no longer subscribed, stop the source.
  • Fix out of date docstring comment.

This is a partial fix for nv-morpheus/Morpheus#1838

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested review from a team as code owners August 28, 2024 16:03
@dagardner-nv dagardner-nv self-assigned this Aug 28, 2024
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Aug 28, 2024
@dagardner-nv
Copy link
Contributor Author

/merge

1 similar comment
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit ca8a73f into nv-morpheus:branch-24.10 Aug 29, 2024
18 checks passed
@dagardner-nv dagardner-nv deleted the david-partial-1838 branch August 29, 2024 19:42
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.05%. Comparing base (bceb7ef) to head (9d61aa3).
Report is 1 commits behind head on branch-24.10.

Files with missing lines Patch % Lines
python/mrc/_pymrc/src/segment.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-24.10     #493      +/-   ##
================================================
- Coverage         74.07%   74.05%   -0.03%     
================================================
  Files               403      403              
  Lines             14401    14403       +2     
  Branches           1132     1132              
================================================
- Hits              10668    10666       -2     
- Misses             3733     3737       +4     
Flag Coverage Δ
cpp 70.81% <0.00%> (-0.04%) ⬇️
py 41.81% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cpp/mrc/src/internal/service.hpp 0.00% <ø> (ø)
python/mrc/_pymrc/src/segment.cpp 81.69% <50.00%> (-0.42%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bceb7ef...9d61aa3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants