Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Descriptor Architecture #486

Draft
wants to merge 20 commits into
base: fea-mnmg
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
5b9c796
Prototype unified singular descriptor class
jadu-nv Jul 8, 2024
25afe54
Remove mrc/codable/type_traits.hpp and introduce requires
jadu-nv Jul 8, 2024
a952ceb
Add complex object to TransferFullDescriptors test and debug deserial…
jadu-nv Jul 8, 2024
a07642d
Refactor callback logic to use shared_ptr rather than tokens and add …
jadu-nv Jul 9, 2024
8d46d14
Fix deferred messaging pull and refactor registration cache
jadu-nv Jul 12, 2024
5010e10
Clean up registration cache code, use std::optional, increase byte si…
jadu-nv Jul 15, 2024
ff5486d
Add support for device memory RDMA and testing
jadu-nv Jul 18, 2024
c27676d
Add initial benchmarking of descriptors
jadu-nv Jul 22, 2024
1584fe9
Bug fix for device memory sent via eager protocol and add async multi…
jadu-nv Jul 25, 2024
7066fa4
Add more benchmark cases and fix typo
jadu-nv Jul 29, 2024
a547dc8
Add test for back pressure of the DataPlane resources object
jadu-nv Jul 29, 2024
c76a12b
Refactor benchmark to achieve async send
jadu-nv Jul 31, 2024
3003dc6
Add async receive with coroutines, streamline benchmarking, and add c…
jadu-nv Aug 6, 2024
23f4661
Add logic to deregister memory from registration cache
jadu-nv Aug 9, 2024
6228e1a
Add TypedDescriptor for storing the type of descriptor
jadu-nv Aug 10, 2024
3c6e273
Refactor receive coroutine to use ClosableRingBuffer
jadu-nv Aug 12, 2024
ef267bc
Add asynchronous sending and new semaphore coroutines library
jadu-nv Aug 13, 2024
11eb547
Add total time and more accurate benchmarking
jadu-nv Aug 14, 2024
3147b96
Fix descriptor tests
jadu-nv Aug 14, 2024
19451ab
Revert changes made to CMake and add thorough commenting
jadu-nv Aug 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cpp/mrc/benchmarks/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,25 @@ add_executable(bench_mrc
main.cpp
bench_mrc.cpp
bench_coroutines.cpp
bench_descriptors.cpp
bench_fibers.cpp
bench_segment.cpp
)

target_link_libraries(bench_mrc
PRIVATE
${PROJECT_NAME}::libmrc
GTest::gtest
benchmark::benchmark
prometheus-cpp::core
)

target_include_directories(bench_mrc
PRIVATE
$<BUILD_INTERFACE:${CMAKE_SOURCE_DIR}/cpp/mrc/src>
$<BUILD_INTERFACE:${CMAKE_SOURCE_DIR}/cpp/mrc/include>
)

add_executable(bench_rxcpp_components
main.cpp
bench_baselines.cpp
Expand Down
Loading
Loading