Update PythonObjectCache to support get and pop operations, update utils to allow passing of cached python objects. #417
Codecov / codecov/project
succeeded
Oct 21, 2024 in 0s
51.98% (-22.03%) compared to b152175
View this Pull Request on Codecov
51.98% (-22.03%) compared to b152175
Details
Codecov Report
Attention: Patch coverage is 14.70588% with 29 lines in your changes missing coverage. Please review.
Project coverage is 51.98%. Comparing base (
b152175) to head (5b2265e).
Report is 40 commits behind head on branch-24.06.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| python/mrc/_pymrc/src/utilities/object_cache.cpp | 0.00% | 18 Missing |
| python/mrc/_pymrc/src/utils.cpp | 31.25% | 11 Missing |
Additional details and impacted files
@@ Coverage Diff @@
## branch-24.06 #417 +/- ##
=================================================
- Coverage 74.00% 51.98% -22.03%
=================================================
Files 394 357 -37
Lines 13955 11492 -2463
Branches 1054 970 -84
=================================================
- Hits 10328 5974 -4354
- Misses 3627 5518 +1891 | Files with missing lines | Coverage Δ | |
|---|---|---|
| ...rc/_pymrc/include/pymrc/utilities/object_cache.hpp | 0.00% <ø> (ø) |
|
| python/mrc/_pymrc/src/segment.cpp | 82.11% <ø> (ø) |
|
| python/mrc/_pymrc/src/utils.cpp | 72.50% <31.25%> (-9.32%) |
⬇️ |
| python/mrc/_pymrc/src/utilities/object_cache.cpp | 57.57% <0.00%> (-21.60%) |
⬇️ |
... and 168 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update b152175...5b2265e. Read the comment docs.
Loading