Skip to content

Commit

Permalink
fix(pwa-utils): ensure joinUrl not modifying scheme part
Browse files Browse the repository at this point in the history
  • Loading branch information
pooya parsa committed Feb 7, 2019
1 parent c233696 commit 09a465a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion packages/pwa-utils/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ function isUrl (url) {
}

function joinUrl (...args) {
return path.join(...args)
return path.join(...args).replace(':/', '://')
}

function getRouteParams (options) {
Expand Down
4 changes: 4 additions & 0 deletions test/fixture/nuxt.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ module.exports = {
description: 'Test Project Description'
},

// build: {
// publicPath: 'https://cdn.com/assets/'
// },

workbox: {
offlineAnalytics: true,
dev: true,
Expand Down

0 comments on commit 09a465a

Please sign in to comment.