bug PHP-CS-Fixer#5012 StrictParamFixer - must run before NativeFuncti…

…onInvocationFixer (kubawerlos)

This PR was merged into the 2.15 branch.

Discussion
----------

StrictParamFixer - must run before NativeFunctionInvocationFixer

Commits
-------

5bec12d StrictParamFixer - must run before NativeFunctionInvocationFixer

src/Fixer/FunctionNotation/NativeFunctionInvocationFixer.php

@@ -176,6 +176,16 @@ public function isRisky()
         return true;
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * Must run after StrictParamFixer.
+     */
+    public function getPriority()
+    {
+        return 0;
+    }
+
     /**
      * {@inheritdoc}
      */

src/Fixer/Strict/StrictParamFixer.php

@@ -53,6 +53,16 @@ public function isRisky()
         return true;
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * Must run before NativeFunctionInvocationFixer.
+     */
+    public function getPriority()
+    {
+        return 1;
+    }
+
     /**
      * {@inheritdoc}
      */

tests/AutoReview/FixerFactoryTest.php

@@ -237,6 +237,7 @@ public function provideFixersPriorityCases()
             [$fixers['standardize_increment'], $fixers['increment_style']],
             [$fixers['standardize_not_equals'], $fixers['binary_operator_spaces']],
             [$fixers['strict_comparison'], $fixers['binary_operator_spaces']],
+            [$fixers['strict_param'], $fixers['native_function_invocation']],
             [$fixers['unary_operator_spaces'], $fixers['not_operator_with_space']],
             [$fixers['unary_operator_spaces'], $fixers['not_operator_with_successor_space']],
             [$fixers['void_return'], $fixers['phpdoc_no_empty_return']],

tests/Fixtures/Integration/priority/strict_param,native_function_invocation.test

@@ -0,0 +1,19 @@
+--TEST--
+Integration of fixers: strict_param,native_function_invocation.
+--RULESET--
+{"strict_param": true, "native_function_invocation": true}
+--EXPECT--
+<?php
+
+function isUtf8($content)
+{
+    return \mb_detect_encoding($content, \mb_detect_order(), true);
+}
+
+--INPUT--
+<?php
+
+function isUtf8($content)
+{
+    return \mb_detect_encoding($content);
+}