bug PHP-CS-Fixer#4994 FinalInternalClassFixer - must run before Prote…

…ctedToPrivateFixer (kubawerlos)

This PR was merged into the 2.15 branch.

Discussion
----------

FinalInternalClassFixer - must run before ProtectedToPrivateFixer

Commits
-------

2821dd2 FinalInternalClassFixer - must run before ProtectedToPrivateFixer

src/Fixer/ClassNotation/FinalInternalClassFixer.php

@@ -72,11 +72,12 @@ public function getDefinition()
     /**
      * {@inheritdoc}
      *
+     * Must run before ProtectedToPrivateFixer.
      * Must run after PhpUnitInternalClassFixer.
      */
     public function getPriority()
     {
-        return 0;
+        return 67;
     }
 
     /**

src/Fixer/ClassNotation/ProtectedToPrivateFixer.php

@@ -53,6 +53,7 @@ protected function test()
      * {@inheritdoc}
      *
      * Must run before OrderedClassElementsFixer.
+     * Must run after FinalInternalClassFixer.
      */
     public function getPriority()
     {

src/Fixer/PhpUnit/PhpUnitInternalClassFixer.php

@@ -49,7 +49,7 @@ public function getDefinition()
      */
     public function getPriority()
     {
-        return 1;
+        return 68;
     }
 
     /**

tests/AutoReview/FixerFactoryTest.php

@@ -94,6 +94,7 @@ public function provideFixersPriorityCases()
             [$fixers['escape_implicit_backslashes'], $fixers['heredoc_to_nowdoc']],
             [$fixers['escape_implicit_backslashes'], $fixers['single_quote']],
             [$fixers['explicit_string_variable'], $fixers['simple_to_complex_string_variable']],
+            [$fixers['final_internal_class'], $fixers['protected_to_private']],
             [$fixers['fully_qualified_strict_types'], $fixers['no_superfluous_phpdoc_tags']],
             [$fixers['function_to_constant'], $fixers['native_function_casing']],
             [$fixers['function_to_constant'], $fixers['no_extra_blank_lines']],

tests/Fixtures/Integration/priority/final_internal_class,protected_to_private.test

@@ -0,0 +1,25 @@
+--TEST--
+Integration of fixers: final_internal_class,protected_to_private.
+--RULESET--
+{"final_internal_class": true, "protected_to_private": true}
+--EXPECT--
+<?php
+/**
+ * @internal
+ */
+final class Foo
+{
+    private $bar;
+    private function baz() {}
+}
+
+--INPUT--
+<?php
+/**
+ * @internal
+ */
+class Foo
+{
+    protected $bar;
+    protected function baz() {}
+}