Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.9.3 #508

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Release/1.9.3 #508

wants to merge 21 commits into from

Conversation

bhati-pradeep
Copy link
Collaborator

No description provided.

Co-authored-by: Gevorg-Khachatryaan <Gevorg1050.1>
* Added fix for module.fail_json, now it takes 2 Arguments. Issue was: #465

* After running black
* add msg if API response cant be converted

Signed-off-by: Thomas Sjögren <[email protected]>

* add default response

Signed-off-by: Thomas Sjögren <[email protected]>

* catch ValueError and increase msg length check

Signed-off-by: Thomas Sjögren <[email protected]>

* revert  msg length check

Signed-off-by: Thomas Sjögren <[email protected]>

* align with code standard

Signed-off-by: Thomas Sjögren <[email protected]>

* fix syntax

Signed-off-by: Thomas Sjögren <[email protected]>

* revert back to the beginning

Signed-off-by: Thomas Sjögren <[email protected]>

---------

Signed-off-by: Thomas Sjögren <[email protected]>
stahnjones and others added 11 commits October 1, 2024 17:39
* change config check to start with ou= for OU

groups don't start with ou= but may be within an OU so would contain ou= in the string. This change makes it so groups don't have to be in the root of the AD.

* Update ntnx_protection_rules.py with start_time check in idempotency check

* update to use get function of dict in case start_time is undefined
* Adding fix for updating empty CD ROM with clone image attribute

* Adding example and test for updating VM with cloning image into CD ROM

* refactoring examples

* Creating seperate example file for updating empty CD ROM
Moving update empty CD ROM test to CRUD operation for IDE disks section

* minor lint fix

* resolving comments

* Adding disk count assertion to assert that number of disks does not change when updating empty CD ROM
Revert "Adding imprv where user can group VMs by project name"
Adding lint checks in pull requests pipelines
@github-actions github-actions bot added the ⚙ ci label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants