-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/1.9.3 #508
Open
bhati-pradeep
wants to merge
21
commits into
main
Choose a base branch
from
release/1.9.3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release/1.9.3 #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gevorg-Khachatryaan <Gevorg1050.1>
* Added fix for module.fail_json, now it takes 2 Arguments. Issue was: #465 * After running black
Signed-off-by: Thomas Sjögren <[email protected]>
* add msg if API response cant be converted Signed-off-by: Thomas Sjögren <[email protected]> * add default response Signed-off-by: Thomas Sjögren <[email protected]> * catch ValueError and increase msg length check Signed-off-by: Thomas Sjögren <[email protected]> * revert msg length check Signed-off-by: Thomas Sjögren <[email protected]> * align with code standard Signed-off-by: Thomas Sjögren <[email protected]> * fix syntax Signed-off-by: Thomas Sjögren <[email protected]> * revert back to the beginning Signed-off-by: Thomas Sjögren <[email protected]> --------- Signed-off-by: Thomas Sjögren <[email protected]>
* change config check to start with ou= for OU groups don't start with ou= but may be within an OU so would contain ou= in the string. This change makes it so groups don't have to be in the root of the AD. * Update ntnx_protection_rules.py with start_time check in idempotency check * update to use get function of dict in case start_time is undefined
* Adding fix for updating empty CD ROM with clone image attribute * Adding example and test for updating VM with cloning image into CD ROM * refactoring examples * Creating seperate example file for updating empty CD ROM Moving update empty CD ROM test to CRUD operation for IDE disks section * minor lint fix * resolving comments * Adding disk count assertion to assert that number of disks does not change when updating empty CD ROM
This reverts commit 1e75a61.
Revert "Adding imprv where user can group VMs by project name"
Adding lint checks in pull requests pipelines
Adding ansible lint fixes for examples directory
Adding imprv where user can group VMs by project name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.