CALM-DSL changes for v3.8.0 #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes the default flow of escript from python2 Escripts to python3 Escripts. (cherry picked from commit 697ea245ea309a597cf0889d196727873b1509c9)
DSL Regression: http://rp.calm.nutanix.com/ui/#calm/launches/all%7Cpage.page=1&page.size=50&page.sort=start_time,number%2CDESC/660ad6f22ab79c0001e261d8 http://rp.calm.nutanix.com/ui/#calm/launches/all%7Cpage.page=1&page.size=50&page.sort=start_time,number%2CDESC/660ad9a82ab79c0001e28485 --------- Co-authored-by: Sumanbshollq <[email protected]> Co-authored-by: Esha-Doda <[email protected]> (cherry picked from commit 9785c5af9555940337e01f5efe1925ab852a51f3)
…Python3 default (#412) Issue Link: https://jira.nutanix.com/browse/CALM-44121 Description: 1. Help commands updated to use default python3 in escripts. (cherry picked from commit f77c8ac548019af236f46268575d257e63f5a324)
Adds new task type that runs python script on remote machines, similar to ssh and powershell tasks. Will be EXEC, SET_VARIABLE and DECISION tasks. --------- Co-authored-by: Prabhat Dwivedi <[email protected]> (cherry picked from commit 6b93a960162d4a859a739ac8271efcc9c2ca3073)
(cherry picked from commit 27cc4b1b4f67ff912b8dffa3f6e69e53ff99a79b)
Before fix:  After fix:  (cherry picked from commit e34f560546e30391a67e991b9ce479fc1bcf19cc)
RCA: Config attr class can be rendered before service class if it is present before in dependepent_entities this may fail decompile scenarios where config attr class has call_runbook action targeting a service action. And service class is not rendered to create RUNBOOK_ACTION_MAP. Fix: Config attr class should be rendered after all other classes are rendered. Additional small fix to remove system defined patch config tasks while decompiling bp from json file. This was present for bp decompile from server. Added for json file bp decompile. Regression: http://erdinger.eng.nutanix.com/blue/organizations/jenkins/QA%2FDSL_Regression/detail/DSL_Regression/619/pipeline/ Affect version: 3.7.2.2, Fix version: 3.8.0 (cherry picked from commit 2586f22978cd6b83d55458347680cabd2b18ff70)
(cherry picked from commit 71369a63f93bab6b4ac4ef5c10359b1348ca0fa4)
1. Added distributed_virtual_switch, vm_recovery_point to all the ACPs. 2. Added report config for Project admin. 3. Added collab independent 3rd index ACP for global entities within the project scope. 4. Moved user and use group to project scope. [CALM-40511](https://jira.nutanix.com/browse/CALM-40511) --------- (cherry picked from commit 09e570a3f1bbc8763e9ee6f878287c270e3b42f3)
I added the project reference in developer ACP for global scope. I added code to check for view_project and then added project references for custom roles. I fixed the Custom Roles filter to add only once if found. E.g. -> Add directory service only once when view/ search directory service permission is present. https://jira.nutanix.com/browse/ENG-612517?focusedId=5605872&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-5605872 (cherry picked from commit 29e49a8dea2552ab1a083b67b513c739f233b57c)
### PR Description __Summary__: Added version check ACP update for system and custom roles. Added check to verify if version < 3.8.0 creates the existing ACPs else create an updated ACP. tkt for ACP update: [ENG-622363](https://jira.nutanix.com/browse/ENG-622363) CALM Version: 3.8.0 __Test Plan__: __Bugs__: [CALM-44401](https://jira.nutanix.com/browse/CALM-44401) __Associated Dependent PR__: __Reviewers__: __Related PRs__: (cherry picked from commit e9c1ed2af1ae5b25175d06c070bed90a326b5e07)
Minor fix for ideadevice/calm-dsl@e9c1ed2 (cherry picked from commit 9cd6e61b7754ef290ea60d5997adcb2b9e49cc42)
(cherry picked from commit 8a94a66dc8f056f580b178be6b19199a6d5f18d6)
(cherry picked from commit a663b2ffad5b97487d936a4536d9bb8123ea4b48)
(cherry picked from commit bf2bc46608956f73d92514292c79e28bacdbdbaf)
abhijeetkaurav1st
approved these changes
May 20, 2024
fabricekrebs
pushed a commit
to fabricekrebs/calm-dsl
that referenced
this pull request
Oct 14, 2024
### Summary Added support to decompile , compile and create dynamic variables that use http task with basic auth ### test decompiled below runbook with dynamic http variable having basic auth <img width="694" alt="Screenshot 2023-10-10 at 6 45 27 PM" src="https://github.com/ideadevice/calm-dsl/assets/89129891/1ddc5893-625d-4f68-b064-7b9a341ff19a"> verified that decompile works correctly. Local file for the basic auth is created and a reference to this is used in the runbook. When create is used the credential is read from the file and stripped, later on the secret is patched. (cherry picked from commit 14424f3e201f8f49b1568755bcf6c18bfbec118c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.