-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS2113-F13-1] Taste of Mom's #49
Open
Aung-Phone-Naing
wants to merge
463
commits into
nus-cs2113-AY2223S2:master
Choose a base branch
from
AY2223S2-CS2113-F13-1:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
463 commits
Select commit
Hold shift + click to select a range
8dd61fa
Merge pull request #63 from YatPang/master
liuziyang020319 82feaef
Strips all leading spaces and converts command words to lower case to…
Aung-Phone-Naing 1529e90
Adds link tto Jar file
Aung-Phone-Naing 38f0529
Fixes minor gramatical error when viewing some dishes with a flavor t…
Aung-Phone-Naing ae028cb
Merge branch 'master' into PE-D-Fixes-Branch
liuziyang020319 ad1a983
Fixes expected output for viewing recipe
Aung-Phone-Naing d5bfaeb
Merge branch 'PE-D-Fixes-Branch' of https://github.com/Aung-Phone-Nai…
Aung-Phone-Naing 4b7abc5
Merge pull request #106 from Aung-Phone-Naing/PE-D-Fixes-Branch
liuziyang020319 758a79e
Fix Issues #92, #102, #103
YatPang 287f24d
Fix Issues #92, #102, #103
YatPang d167880
Fix Issues #92, #97, #102, #103
YatPang dbcd99f
Fetch add edit feature
liuziyang020319 1a7f3a4
Fix Issues #69, #92, #97, #102, #103
YatPang 698397e
Fix Issues #69, #92, #97, #102, #103
YatPang 268fd28
Fix Issues #69, #92, #97, #102, #103
YatPang ff3d52b
Fix Issues #69, #92, #97, #102, #103
YatPang 4ba790f
Merge pull request #107 from YatPang/master
Aung-Phone-Naing 13291d7
Follow-Up on #107
YatPang 043e560
Follow-Up on #107
YatPang bdd960a
Merge pull request #108 from YatPang/master
Aung-Phone-Naing 76007db
Merge branch 'master' of https://github.com/AY2223S2-CS2113-F13-1/tp
liuziyang020319 d00512d
Fetch: Add edit method
liuziyang020319 1b37db9
Fix Issues #83
YatPang 4705697
Merge pull request #110 from YatPang/master
LimHongYao dd4a982
Fixed out of bounds handling for ingredientList
LimHongYao 05ca1b2
Removes the SAVE SUCCESS srtring from file writing method,
Aung-Phone-Naing e2a9086
Changes VIEW command instruction
Aung-Phone-Naing 58b84c4
Merge branch 'master' into PE-D-Fixes-Branch
Aung-Phone-Naing b1be50e
Add JUnit test for searchByTag
YatPang 3eb93bd
Merge branch 'AY2223S2-CS2113-F13-1:master' into master
YatPang 7bb8873
Resolve merge conflict
Aung-Phone-Naing 36fbe83
Fixes merge conflict
Aung-Phone-Naing dfcac8f
Add JUnit test for searchByTag
YatPang 919a5e1
Merge pull request #112 from YatPang/master
LimHongYao 2dfd149
Merge branch 'master' of https://github.com/AY2223S2-CS2113-F13-1/tp
liuziyang020319 ac3d9cc
Fetch: fixed coflict
liuziyang020319 a4d587d
Fetch: Fixed lay out bug
liuziyang020319 7ee5bab
Fixed
liuziyang020319 b8c9270
Merge pull request #109 from liuziyang020319/master
YatPang de264d5
Fix Issue #82
YatPang 365cbb7
Merge remote-tracking branch 'origin/master'
YatPang 85ffe83
Fix Issue #82
YatPang 300f81a
Fix Issue #82
YatPang 179f4ef
Change Save Format
YatPang ed62516
Change Save Format
YatPang 8f8fdf8
Fixes indentation
Aung-Phone-Naing 800a002
Merge branch 'master' into PE-D-Fixes-Branch
Aung-Phone-Naing bc967d9
Fixes string variable name
Aung-Phone-Naing 117a8e8
Fixes String variable classifier
Aung-Phone-Naing 8041ae2
Fixes String declaration order
Aung-Phone-Naing d890a29
Reorders variable declaration
Aung-Phone-Naing 85e7fd7
Fixes "View" to "Find"
Aung-Phone-Naing 9648606
Fixes last instance of "View" to "Find"
Aung-Phone-Naing 86dc042
Fixes texts in Expected text to reflect actual output
Aung-Phone-Naing 1b0c6f4
Merge pull request #111 from Aung-Phone-Naing/PE-D-Fixes-Branch
YatPang e6e4e7d
Merge branch 'AY2223S2-CS2113-F13-1:master' into master
YatPang c50fd56
Merge pull request #114 from YatPang/master
Aung-Phone-Naing 1db9fe9
no message
LimHongYao f05b702
Merge branch 'master' of https://github.com/LimHongYao/tp
LimHongYao 836e0f0
added text-ui for out of bounds edit instructions
LimHongYao 172c00a
Created some test cases for editIngredient
LimHongYao 7b35d47
Modified stepbystep corrections to clear ambiguity
LimHongYao 5cf324b
prepared object class level methods for add/remove ingredient/step me…
LimHongYao 831c2d2
Create ListEmptyException (general use)
LimHongYao 859ea19
modified editIngredient method for easier testing
LimHongYao a0e31c8
add basic edit ingredient test
LimHongYao a876329
Further modification of editIngredient method to ease testing
LimHongYao 55c5d8d
DG bold formatting issue fix
LimHongYao ebc4a4b
Create editStep junit
LimHongYao dfdf60c
formatting fixes
LimHongYao 4f2fe86
remove extra curly
LimHongYao 7d6ec59
clear confusion between overload methods
LimHongYao d7db903
Added basic editStep junit test
LimHongYao 3491691
remove unused import
LimHongYao 6467134
restore deleted empty editTest junit
LimHongYao c62b1fe
Merge pull request #115 from LimHongYao/master
LimHongYao d3bb227
Add AddToRecipe (Step/Ingredient)
YatPang 1586b22
Add AddToRecipe (Step/Ingredient)
YatPang f313b49
Add AddToRecipe (Step/Ingredient)
YatPang 5ee679e
Add DeleteFromRecipe (Step/Ingredient)
YatPang 4930203
Adds PPP content
Aung-Phone-Naing 42f3e93
Merge branch 'PE-D-Fixes-Branch'
Aung-Phone-Naing c9e3f03
Updates the following:
Aung-Phone-Naing 51b8636
Updates Components
Aung-Phone-Naing cd3dfad
Updates FindRecipe plant uml diagram
Aung-Phone-Naing 3da840d
Updates DG format
Aung-Phone-Naing b49edbf
Implements Singleton for RecipeList class
Aung-Phone-Naing ddcd67a
Fixes declaration order and style check issues
Aung-Phone-Naing 51edb7e
Merge pull request #117 from Aung-Phone-Naing/DG-Improvements
LimHongYao 48816b5
Merge branch 'AY2223S2-CS2113-F13-1:master' into master
YatPang c3c6bf4
Add AddToRecipe (Step/Ingredient), DeleteFromRecipe (Step/Ingredient)
YatPang c1051cd
Add AddToRecipe (Step/Ingredient), DeleteFromRecipe (Step/Ingredient)
YatPang d1c0e8f
Fixes UG for View feature
Aung-Phone-Naing 85ad2f5
no message
liuziyang020319 7464c50
Merge branch 'master' of https://github.com/AY2223S2-CS2113-F13-1/tp
liuziyang020319 9184b25
Add AddToRecipe (Step/Ingredient), DeleteFromRecipe (Step/Ingredient)…
YatPang 77c3992
no message
liuziyang020319 115821b
removed support for scrapped feature: timed step
LimHongYao 4fbc445
Step-by-step view now automatically terminates when the last step has…
LimHongYao ddf3c1c
forgot to change expected.txt hehe xD
LimHongYao c9ee317
Add AddToRecipe (Step/Ingredient), DeleteFromRecipe (Step/Ingredient)
YatPang 96a710a
Refactor AddToRecipe (Step/Ingredient), DeleteFromRecipe (Step/Ingred…
YatPang ae72cfa
Merge pull request #118 from LimHongYao/master
liuziyang020319 476bce1
Add AddToRecipe (Step/Ingredient), DeleteFromRecipe (Step/Ingredient)
YatPang bd9ffe4
Merge remote-tracking branch 'origin/master'
YatPang cbe6f1b
Add AddToRecipe (Step/Ingredient), DeleteFromRecipe (Step/Ingredient)
YatPang 601ad17
Add AddToRecipe (Step/Ingredient), DeleteFromRecipe (Step/Ingredient)
YatPang b86a2e9
Add AddToRecipe (Step/Ingredient), DeleteFromRecipe (Step/Ingredient)
YatPang 53db7a2
Add AddToRecipe (Step/Ingredient), DeleteFromRecipe (Step/Ingredient)
YatPang 3e5d857
Add AddToRecipe (Step/Ingredient), DeleteFromRecipe (Step/Ingredient)
YatPang 9ed0bb9
Add AddToRecipe (Step/Ingredient), DeleteFromRecipe (Step/Ingredient)
YatPang 7131d86
Add AddToRecipe (Step/Ingredient), DeleteFromRecipe (Step/Ingredient)
YatPang 77948d1
Add AddToRecipe (Step/Ingredient), DeleteFromRecipe (Step/Ingredient)
YatPang 2964580
Change RecipeView and RecipeManage sequence diagrams
Aung-Phone-Naing d7bd894
Fixes bug in Find Recipe sequence diagram
Aung-Phone-Naing 6d0e378
Fixes Help sequence diagram
Aung-Phone-Naing ba5ceb7
Fetch: add exception handle in numberoverflow
liuziyang020319 f3e277f
Merge branch 'master' into master
liuziyang020319 cf3dee9
Fixes Help sequence diagram
Aung-Phone-Naing e333c3c
Add photos
liuziyang020319 d734a7d
Merge pull request #123 from liuziyang020319/master
Aung-Phone-Naing 90ee126
Merge branch 'master' of https://github.com/liuziyang020319/tp
liuziyang020319 fcb985e
Format fix
liuziyang020319 b539f58
Merge remote-tracking branch 'origin/master'
YatPang b952884
Adds sequence diagram for recipe steps edit feature
Aung-Phone-Naing 4730087
Add Flexibility to AddToRecipe command and DeleteFromRecipe command
YatPang 0afbb62
Add Flexibility to AddToRecipe command and DeleteFromRecipe command
YatPang c24f670
Add Flexibility to AddToRecipe command and DeleteFromRecipe command
YatPang 3de54d5
Add Flexibility to AddToRecipe command and DeleteFromRecipe command
YatPang ec98a81
Fixes error log for VIEW feature
Aung-Phone-Naing 43ee87c
Adds constrain for ADD feature
Aung-Phone-Naing 11bbbe6
Merge pull request #124 from YatPang/master
LimHongYao 8ccea7b
Merge branch 'master' of https://github.com/AY2223S2-CS2113-F13-1/tp
liuziyang020319 75c2d52
Fix couting bugs
liuziyang020319 d00c126
Implements error to reject numerical only input and special character…
Aung-Phone-Naing f8ab184
Updates minor language for VIEW feature
Aung-Phone-Naing 84aa7e8
Merge branch 'Constrain-Add-Recipe-Input-Branch' into DG-Improvements
Aung-Phone-Naing b2f2ff4
no message
liuziyang020319 63a42a2
Fixed: checkstyle
liuziyang020319 cf639ab
Fixed some bugs in addtorecipe and deletefromrecipe
liuziyang020319 2690ffd
Fixed: checkstyle bugs
liuziyang020319 1842fcc
Fixed: syntax mistake
liuziyang020319 5224c1c
Fix checkstyle bugs
liuziyang020319 dc75167
Update Yat Pang's PPP
YatPang 1d30f73
Merge pull request #129 from liuziyang020319/master
LimHongYao 7926fd2
Merge branch 'AY2223S2-CS2113-F13-1:master' into master
YatPang 2c160b2
add hongyao's photo
LimHongYao 01280ec
Fixes sequence diagrams and DG format with InvalidInputCharacterExcep…
Aung-Phone-Naing 4f40b20
Merge pull request #130 from YatPang/master
LimHongYao 02eb44c
Merge branch 'AY2223S2-CS2113-F13-1:master' into master
LimHongYao 7bde6e4
Fixes the deactivation of Commands in sequence diagram to extend unti…
Aung-Phone-Naing 227b8ed
Updates DG Instructions for Manual Testing along with removal of v3.0…
Aung-Phone-Naing 40ee966
Merge pull request #131 from LimHongYao/master
Aung-Phone-Naing 04c15de
Merge branch 'DG-Improvements'
Aung-Phone-Naing d121f14
Merge branch 'master' of https://github.com/Aung-Phone-Naing/tp
Aung-Phone-Naing b1256fe
Fixes visual bug in DG for VIEW feature
Aung-Phone-Naing 0b67ab2
Merge pull request #132 from Aung-Phone-Naing/master
LimHongYao 89def7d
Add Yat Pang's image
YatPang 124e636
Merge pull request #133 from YatPang/master
Aung-Phone-Naing deda078
Update YatPang's PPP and UG
YatPang 3ea0289
Fetch: fix some changes in UG
liuziyang020319 fdbce9b
Merge pull request #134 from YatPang/master
liuziyang020319 5260efd
Modify: rename the file as a correct name
liuziyang020319 a518844
Merge branch 'master' of https://github.com/AY2223S2-CS2113-F13-1/tp
liuziyang020319 605a8a6
Fetch: Add some increment of PPP
liuziyang020319 f4ad9fb
Add the most part of PPP
liuziyang020319 05850c0
Update the table
liuziyang020319 bf88789
Try to fix the layout
liuziyang020319 9fd2639
Fix another layout issue
liuziyang020319 fa76281
Fix another bugs
liuziyang020319 85cbdd0
Merge pull request #135 from liuziyang020319/master
Aung-Phone-Naing 374f514
no message
Aung-Phone-Naing 9b213b9
Revert "no message"
Aung-Phone-Naing 00e38c7
Merge branch 'master' of https://github.com/Aung-Phone-Naing/tp
Aung-Phone-Naing 59c3b43
Modify: Fix PPP layout
liuziyang020319 cbd0d72
Updates PPP and DG welcome messgage to picture
Aung-Phone-Naing 9540501
Fix bug in UG
liuziyang020319 d4466cc
Merge pull request #136 from Aung-Phone-Naing/master
liuziyang020319 f1f90e8
Merge pull request #137 from liuziyang020319/master
LimHongYao 5590a68
update README to remove duke
LimHongYao 93de60d
Updated PPP to match set formatting
LimHongYao 39062f4
Add default case/else condition warnings for code quality
LimHongYao ca4c7af
editStep and editIngredient handling of non-number and overflow inputs
LimHongYao adcb7f7
remove unused import
LimHongYao d222ce6
Merge pull request #138 from LimHongYao/master
YatPang 3da2537
Updates App description for README and UG
Aung-Phone-Naing e3bcc06
Merge branch 'master' of https://github.com/Aung-Phone-Naing/tp
Aung-Phone-Naing 04d4c94
Fixes UG description for deletefromrecipe feature
Aung-Phone-Naing 1b29b0e
Minor UG formatting fix
Aung-Phone-Naing db6ca78
Updates UG to add specification for quick start
Aung-Phone-Naing 5f9f0c4
Merge pull request #139 from Aung-Phone-Naing/master
LimHongYao 0963ac9
Fixes UG description for addtorecipe
Aung-Phone-Naing 70369ce
Fixes UG expected strings for view feature
Aung-Phone-Naing ad527d1
Updates UG view strings
Aung-Phone-Naing 551ee0a
fixed bug where delete to less than 1 ingredient is possible
LimHongYao 48bafb7
fixed empty recipe list output for addtoingredient
LimHongYao 3053042
Updates help messgae to include all commands and minor UG format tabl…
Aung-Phone-Naing 996cdcb
Merge branch 'AY2223S2-CS2113-F13-1:master' into master
Aung-Phone-Naing 03d1350
Fixes formatting error in StringLib
Aung-Phone-Naing 423b582
solved same issue for deletefromrecipe
LimHongYao c2b588a
req expected
LimHongYao 6a31b6a
removed unused imports
LimHongYao f2385db
fix tests
LimHongYao 3287077
Merge pull request #141 from LimHongYao/master
YatPang 164cd90
Merge branch 'AY2223S2-CS2113-F13-1:master' into master
Aung-Phone-Naing ad315e0
Merge pull request #140 from Aung-Phone-Naing/master
LimHongYao 3dae67b
Fix markdown bugs
liuziyang020319 ebfe01e
Merge branch 'master' of https://github.com/AY2223S2-CS2113-F13-1/tp
liuziyang020319 f573770
Changes name of PPP to match github username
Aung-Phone-Naing 5ba4ccb
Merge branch 'master' into master
liuziyang020319 8a68cba
Updates DG acknowledgements
Aung-Phone-Naing 7bfbb77
insert missing ingredient edit implementation
LimHongYao e6834ba
Merge pull request #142 from liuziyang020319/master
Aung-Phone-Naing 5320d42
Fix layout bugs
liuziyang020319 2fd5b02
Merge branch 'master' of https://github.com/liuziyang020319/tp
liuziyang020319 e2a17ba
Fixes Delete feature Number Format Exception error message
Aung-Phone-Naing 933d3c7
Merge branch 'AY2223S2-CS2113-F13-1:master' into master
Aung-Phone-Naing 6abbe77
add misisng step and example usage
LimHongYao 9b002bf
Merge pull request #143 from LimHongYao/master
Aung-Phone-Naing 7faf7a6
Merge pull request #144 from Aung-Phone-Naing/master
LimHongYao a6c94ac
Merge branch 'master' of https://github.com/AY2223S2-CS2113-F13-1/tp
liuziyang020319 15ee28b
Merge remote-tracking branch 'upstream/master'
liuziyang020319 7a873fd
Fix grammar bugs in log
liuziyang020319 bbdb20c
grammar check for recipelist
LimHongYao b71c052
Merge pull request #145 from liuziyang020319/master
LimHongYao 2982656
Change StepsList Grammar
Aung-Phone-Naing ce3e9f4
fixed grammar for add and delete commands
LimHongYao 7cb803d
Merge pull request #146 from LimHongYao/master
liuziyang020319 8263c28
Fixes step delete quit message grammar
Aung-Phone-Naing cc032cd
Merge branch 'AY2223S2-CS2113-F13-1:master' into master
Aung-Phone-Naing ef76dd8
Merge pull request #147 from Aung-Phone-Naing/master
LimHongYao 91ef522
UG grammar fixed
liuziyang020319 dba1b33
Fixes DG bugs on github pages
Aung-Phone-Naing 62c1317
Merge pull request #149 from Aung-Phone-Naing/master
LimHongYao 8b06c76
Merge pull request #148 from liuziyang020319/master
Aung-Phone-Naing 2874a6a
Final UG format fixes
Aung-Phone-Naing 548bd7d
Final DG format fixes
Aung-Phone-Naing eb4f05c
Merge pull request #150 from Aung-Phone-Naing/master
Aung-Phone-Naing 6677071
PPP finalised
LimHongYao 5550e66
Merge branch 'AY2223S2-CS2113-F13-1:master' into master
LimHongYao 8924ab7
Merge pull request #151 from LimHongYao/master
YatPang b43792c
Update YatPang's PPP
YatPang aedeef7
Merge pull request #152 from YatPang/master
Aung-Phone-Naing 79fd1cb
Adds Phone's PPP
Aung-Phone-Naing 1ff4e21
Merge branch 'AY2223S2-CS2113-F13-1:master' into master
Aung-Phone-Naing 8ebb4bb
Merge pull request #153 from Aung-Phone-Naing/master
LimHongYao f3fd69d
Update PPP
Aung-Phone-Naing daadd13
Merge branch 'AY2223S2-CS2113-F13-1:master' into master
Aung-Phone-Naing 71ab057
Adds more PRs to PRs reviewed for PPP
Aung-Phone-Naing 197e200
Merge pull request #154 from Aung-Phone-Naing/master
YatPang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,3 +15,6 @@ bin/ | |
|
||
/text-ui-test/ACTUAL.TXT | ||
text-ui-test/EXPECTED-UNIX.TXT | ||
|
||
# Ignore Data | ||
/data |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package seedu.duke.command; | ||
|
||
public enum EditType { | ||
ingredient, | ||
step, | ||
INGREDIENT, STEP, OTHER | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package seedu.duke.exceptions; | ||
|
||
public class EditFormatException extends Exception { | ||
public EditFormatException(String message) { | ||
super(message); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
package seedu.duke.command; | ||
|
||
public class EditTest { | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job minimising the use of magic strings here! But do consider changing as many magic strings to constants as possible!