-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS2113-F10-2] BadMaths #46
Open
YC-Michael
wants to merge
719
commits into
nus-cs2113-AY2223S2:master
Choose a base branch
from
AY2223S2-CS2113-F10-2:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
719 commits
Select commit
Hold shift + click to select a range
89d5cf1
refactoring magic literals to improve readability
CVRP-SOLE 8f6864d
Implement JUnit Tests for CommandHistory.java
WilsonLee2000 5f7e0e6
Merge pull request #229 from ZiqiuZeng/branch-NotesFileWriter-JUnit-Test
ZiqiuZeng 355c4b1
update imports for NotesFileWriterTest
ZiqiuZeng fee543b
Merge pull request #237 from WilsonLee2000/TestJUnit
WilsonLee2000 1b80b65
Improve readability of UG
CVRP-SOLE 8f9eb9d
Merge pull request #238 from ZiqiuZeng/branch-NotesFileWriterTest-Update
WilsonLee2000 54b3dfd
no message
CVRP-SOLE 1704811
Merge remote-tracking branch 'origin/test'
CVRP-SOLE e8d1ef8
Merge pull request #234 from khooyourun/PPP
ZiqiuZeng 377beb4
Merge pull request #240 from 0nandon/master
0nandon 3a8d181
no message
CVRP-SOLE c4e26b7
Implement DeleteTest.java
WilsonLee2000 5976f10
removing comments that are private notes to me
CVRP-SOLE 2b72547
Implement JUnit Tests for List.java
WilsonLee2000 6fffb2c
Merge pull request #243 from WilsonLee2000/TestJUnit
0nandon fc3c8ec
refactoring long methods
CVRP-SOLE 683e833
Merge pull request #244 from 0nandon/master
WilsonLee2000 d461feb
Merge branch 'TestJUnit'
WilsonLee2000 eb53ad7
Update draft PPP
ZiqiuZeng 43d46f9
Merge pull request #248 from ZiqiuZeng/branch-Draft-PPP
ZiqiuZeng 46f1669
delete unused imports
ZiqiuZeng d02cf4f
refactor classes into corresponding packages
ZiqiuZeng c7b1455
handle redundant imports
ZiqiuZeng c0a6d3a
Create seungjun_lee.md
0nandon 557bd87
Update seungjun_lee.md
0nandon 7e57b24
Delete seungjun_lee.md
0nandon 1c804df
Create seungjun_lee.md
0nandon c49bf6a
Merge pull request #249 from ZiqiuZeng/branch-tP-review-readability
0nandon 3a3dde4
Merge pull request #250 from 0nandon/master
ZiqiuZeng 2f11a3a
Change name of the PPP
CVRP-SOLE 6239f16
Merge pull request #251 from 0nandon/master
ZiqiuZeng 3ea091c
Merge remote-tracking branch 'origin/master'
WilsonLee2000 0067039
Implement PPP
WilsonLee2000 57f9c28
Further Enhancements towards PPP
WilsonLee2000 852ffc3
Addition of PPP content
WilsonLee2000 ea2190e
Finish up remaining PPP. PPP is ready to be merged.
WilsonLee2000 6831858
Merge pull request #252 from WilsonLee2000/PPP
WilsonLee2000 08e91d5
Merge branch 'PPP'
WilsonLee2000 81a7f8b
Merge branch 'AY2223S2-CS2113-F10-2:master' into master
WilsonLee2000 9fefef0
Delete unnecessary text files
ZiqiuZeng c32b2c4
Refactor loadFile() method in NotesFileParser
ZiqiuZeng dcc4edd
Update JUnit test for NotesFileCleaner
ZiqiuZeng 45e3d68
Update JUnit Test for NotesFileWriter
ZiqiuZeng a466230
Add JUnit Test for NotesFileHandler
ZiqiuZeng ada2687
Add JUnit Test for NoteParser
ZiqiuZeng e7e4b3b
Handle unused imports
ZiqiuZeng 13428cd
Handle encoding issues
ZiqiuZeng 9a0f544
handle encoding problems for "\n\n"
ZiqiuZeng 2c5f3fb
modify expectedOutput with platform-independent line separators
ZiqiuZeng 2084741
handle length problem
ZiqiuZeng 1eb66ed
Further refined Developer's Guide and Added collapsible section for a…
WilsonLee2000 1bc9e92
Rectify issues on StoreTest.java
WilsonLee2000 7526ec5
Added Developer Guide Description for Store, List, Delete, and Comman…
WilsonLee2000 b0cc664
Refine Developer Guide for Command class
WilsonLee2000 87849aa
Merge pull request #255 from WilsonLee2000/DGPPP
WilsonLee2000 016cdd7
Update UML for graph
YC-Michael 0346c76
Merge branch 'master' of https://github.com/AY2223S2-CS2113-F10-2/tp …
YC-Michael d40880e
Merge pull request #254 from ZiqiuZeng/branch-refactor-loadFile
ZiqiuZeng 6a98ef2
Update UML for graph and organise file paths for docs folder.
YC-Michael 598b753
Merge pull request #256 from YC-Michael/branch-uml-graph
YC-Michael 773405b
Added class diagrams for Quadratic and interpretation of user input
khooyourun 00831e6
Further edits to UG and DG
khooyourun 18c1e3a
Merge pull request #257 from khooyourun/UML_diagrams
khooyourun 91eec50
added architecture diagram
khooyourun d9067a7
edited UG and DG to fix TOC links
khooyourun f2e710c
Merge pull request #258 from khooyourun/UML_diagrams
khooyourun ba41834
Sequence Diagram DG for Store
WilsonLee2000 ffef03e
Add Ui.printAddNote for Sequence Diagram DG
WilsonLee2000 21fc161
Reflect updated Sequence Diagram on DG
WilsonLee2000 00bb7fb
Merge pull request #259 from WilsonLee2000/SequenceDiagramDG
WilsonLee2000 f155eab
Resolve activate store and deactivate store + remove duplicate images
WilsonLee2000 67b35bb
Implement Logging for Store.java
WilsonLee2000 ad5f292
Removed logging
WilsonLee2000 5312aa6
Merge pull request #260 from WilsonLee2000/SequenceDiagramDG
WilsonLee2000 373f635
Merge branch 'SequenceDiagramDG'
WilsonLee2000 61c96df
Merge branch 'master' of https://github.com/AY2223S2-CS2113-F10-2/tp
WilsonLee2000 748d79f
Merge branch 'AY2223S2-CS2113-F10-2:master' into master
WilsonLee2000 1d2deed
Merge branch 'master' of https://github.com/WilsonLee2000/tp
WilsonLee2000 67eaa81
Update UG and removed the . from "Prioritize a Note" section from UG
WilsonLee2000 2f9b64a
Remove .
WilsonLee2000 4d17726
Finish PPP
WilsonLee2000 2566718
Merge pull request #262 from WilsonLee2000/PPPFinal
WilsonLee2000 b4aa697
Merge branch 'PPPFinal'
WilsonLee2000 b620c48
Merge branch 'AY2223S2-CS2113-F10-2:master' into master
WilsonLee2000 5d0655e
Merge branch 'master' of https://github.com/AY2223S2-CS2113-F10-2/tp
WilsonLee2000 6f05e9e
Merge branch 'master' of https://github.com/WilsonLee2000/tp
WilsonLee2000 21f67f5
Fix the matrix bug reported from PED
CVRP-SOLE 3fef76f
Fix PR error
CVRP-SOLE b3e69c1
Added documentations
WilsonLee2000 2c22682
update sequence diagram for NotesFileParser
ZiqiuZeng cd290e1
Remove additional line at HelpManual
WilsonLee2000 0592c82
Add activation bar for InvalidFormatException
ZiqiuZeng 56af6b0
Merge pull request #266 from khooyourun/Additional_UG_DG_edits
khooyourun 28613c4
Merge pull request #264 from WilsonLee2000/Documentations
WilsonLee2000 2543b88
Merge branch 'Documentations'
WilsonLee2000 a4c0aa6
Merge branch 'master' of https://github.com/AY2223S2-CS2113-F10-2/tp
WilsonLee2000 34196e7
Minor rectifications to better phrase developer guide
WilsonLee2000 568f637
Revert "Minor rectifications to better phrase developer guide"
WilsonLee2000 4b122a4
Removed Unecessary Working comments when implementing the features, a…
WilsonLee2000 28ced57
Delete functions that were flagged out as not needed at Command.java
WilsonLee2000 a428acc
Add more stuff for DG
WilsonLee2000 721ece4
Improve the DG
WilsonLee2000 ebf9859
Improve DG for historyCommand
WilsonLee2000 0f3484c
Formatting Test.java
WilsonLee2000 ad7b1a6
Format Tests.java
WilsonLee2000 faec2da
Merge pull request #263 from 0nandon/master
0nandon a334a59
update Rank Review Count in HelpManual.txt
ZiqiuZeng d1d62b4
handle index problem for printPriority()
ZiqiuZeng 555d18f
correct information in ug
ZiqiuZeng 538fb6f
update PPP-ziqiu
ZiqiuZeng 838da54
update ToC
ZiqiuZeng 97de1e5
Merge pull request #267 from WilsonLee2000/DocumentationsEdit
WilsonLee2000 d12e8aa
Update PPP website
WilsonLee2000 21758c9
Merge pull request #269 from ZiqiuZeng/branch-ppp-final
ZiqiuZeng 436c169
Merge pull request #268 from ZiqiuZeng/branch-proofread-ug
ZiqiuZeng e76bc92
Merge pull request #270 from WilsonLee2000/DocumentationsEdit
khooyourun 64f6316
Merge branch 'DocumentationsEdit'
WilsonLee2000 b9e793d
Remove unused Sequence Diagram
WilsonLee2000 d07b437
Edit AboutUs
d6a75c6
Merge pull request #272 from YC-Michael/Edit_Admin_Stuff
WilsonLee2000 95cca58
Further refine to PPP
WilsonLee2000 83ee6e8
split long sequence diagram
ZiqiuZeng 4bae805
update dg
ZiqiuZeng 6d998f1
Merge pull request #271 from WilsonLee2000/DGDeletion
WilsonLee2000 4769b65
Merge branch 'DGDeletion'
WilsonLee2000 627c505
delete unused class
ZiqiuZeng 92ecfde
toc edits for UG
khooyourun da76d45
refactor `Team` to `team`
ZiqiuZeng 9bbad9d
Merge pull request #274 from ZiqiuZeng/renaming-team-folder
WilsonLee2000 6ca8002
Merge pull request #273 from ZiqiuZeng/branch-delete-unused-class
WilsonLee2000 c38ccbf
Edit StoreTest.java
WilsonLee2000 4142633
Merge pull request #276 from AY2223S2-CS2113-F10-2/UG_DG_edits
khooyourun afb5057
Edit AboutUs
f9d5897
Merge pull request #277 from YC-Michael/Edit_Admin_Stuff
khooyourun 1fa7c85
Merge pull request #275 from WilsonLee2000/EditStoreTest
WilsonLee2000 ab8829d
Merge pull request #265 from ZiqiuZeng/branch-UML
ZiqiuZeng 0693727
Added newline after commands and fixed DG TOC. Changed "Bye" to Syste…
khooyourun 3da6820
Updated expected text file
khooyourun 8270ff6
Edit README.md
831c837
Merge pull request #278 from AY2223S2-CS2113-F10-2/Newline_and_UG_TOC
khooyourun 017f1cd
Merge pull request #279 from YC-Michael/Edit_Admin_Stuff
YC-Michael fed2a4c
Remove irrelevant lines in DG and updated release link in UG.
455a0a9
Resolve indentation issues
WilsonLee2000 f76f41f
Merge pull request #280 from YC-Michael/Edit_Admin_Stuff
khooyourun 34f0330
Added profile pic in AboutUs.md
995f8d2
Merge pull request #281 from WilsonLee2000/EditStoreTest
WilsonLee2000 687239a
Merge branch 'EditStoreTest'
WilsonLee2000 e0d952f
added profile picture under AboutUs
khooyourun 3ef8200
Merge branch 'AY2223S2-CS2113-F10-2:master' into master
WilsonLee2000 25292ea
Merge branch 'master' of https://github.com/AY2223S2-CS2113-F10-2/tp
WilsonLee2000 b11abe6
Merge branch 'master' of https://github.com/WilsonLee2000/tp
WilsonLee2000 4220d6c
Merge pull request #282 from YC-Michael/Edit_Admin_Stuff
khooyourun be22905
Merge branch 'master' into Profile_Photo
khooyourun 521cdef
Merge pull request #283 from AY2223S2-CS2113-F10-2/Profile_Photo
YC-Michael ff8c533
update dg for storage
ZiqiuZeng e5d0580
Added profile pic in AboutUs.md
652b4d0
Merge branch 'master' of https://github.com/AY2223S2-CS2113-F10-2/tp …
14abae2
Added profile pic in AboutUs.md
362a254
Merge pull request #285 from YC-Michael/Edit_Admin_Stuff
khooyourun b68d8d4
Merge pull request #284 from ZiqiuZeng/dg-final
ZiqiuZeng b18bdac
Fixed Quadratic sequence diagram
khooyourun 343b5e4
Update link for reposense code
WilsonLee2000 2a3f0e0
Indentation for Test
WilsonLee2000 eb96956
Edit PPP
WilsonLee2000 3c9335c
Delete unused NotesTest
WilsonLee2000 07b02b7
added pics to AboutUs
khooyourun a9cd961
Merge pull request #286 from AY2223S2-CS2113-F10-2/sequence_diagram_e…
khooyourun 6d66f0a
update acknowledgement
ZiqiuZeng 8c64613
Merge pull request #287 from WilsonLee2000/EditPPP
WilsonLee2000 bac4701
Merge pull request #288 from ZiqiuZeng/master
ZiqiuZeng acd614b
Merge branch 'EditPPP'
WilsonLee2000 8cd149a
Merge branch 'AY2223S2-CS2113-F10-2:master' into master
WilsonLee2000 96d0797
Merge branch 'master' of https://github.com/AY2223S2-CS2113-F10-2/tp
WilsonLee2000 173bc98
Merge branch 'master' of https://github.com/WilsonLee2000/tp
WilsonLee2000 49b7b53
Refine PPP
WilsonLee2000 63e5156
Singular to Plural
WilsonLee2000 967e0bb
Add class diagram in DG for the matrix part, and add some datails
CVRP-SOLE ae45285
Merge pull request #289 from WilsonLee2000/PPPFinalEdit
0nandon 17bdd5c
Merge pull request #290 from 0nandon/master
0nandon b89eb09
Add seungjun profile
CVRP-SOLE 305b46f
Update AboutUs.md
0nandon 14b5a1e
Update sequence diagram for graph
YC-Michael 8d49bb4
Update sequence diagram for graph
YC-Michael 26b7abc
Update UG for Graph
YC-Michael 8bdbb75
Merge pull request #291 from YC-Michael/master
YC-Michael 6c3e850
fixed Quadratic sequence diagram and user stories formating
khooyourun 16636bc
Merge pull request #292 from khooyourun/UG_DG_final_edits
khooyourun 271077b
update acknowledgement
ZiqiuZeng 38cc0de
Merge branch 'PPPFinalEdit'
WilsonLee2000 3c9ee23
Refine Seungjun's PPP
CVRP-SOLE 791a143
Merge pull request #293 from ZiqiuZeng/update-acknowledgement
ZiqiuZeng b1c5a19
Refine Seungjun's PPP
CVRP-SOLE dafd829
Rectify DG Sequence Diagram
WilsonLee2000 dcc29cd
Resolve indentation issues
WilsonLee2000 f05d350
Rectify bugs
WilsonLee2000 d717b3f
editted user stories
khooyourun 18da3ef
Delete redundant images
WilsonLee2000 69ce099
update sequence diagrams for file loading
ZiqiuZeng e7d38c6
Remove redundant images
WilsonLee2000 3b661a3
Merge pull request #295 from 0nandon/master
khooyourun f4cdc2a
Merge pull request #294 from WilsonLee2000/DGbug
WilsonLee2000 36e675d
Merge pull request #296 from khooyourun/final_final_DG_edits
khooyourun 3743344
fixed sequence diagram not showing
khooyourun 2b6f526
update profile pic
ZiqiuZeng 851a8a2
Merge pull request #299 from ZiqiuZeng/add-profile
khooyourun f0e7bd0
Merge pull request #298 from khooyourun/Store_sequence_diagram
khooyourun b9995f0
Merge pull request #297 from ZiqiuZeng/update-sequence-diagram
khooyourun 5d41923
fix activation bar problem
ZiqiuZeng bfa379a
Merge pull request #300 from ZiqiuZeng/handle-diagram-problem
khooyourun 042fae6
Remove Store seq diagram for reimplementation
WilsonLee2000 42483f6
Add Sequence Diagram for Store
WilsonLee2000 092b43c
Merge pull request #301 from WilsonLee2000/fixstoreseqdiagram
WilsonLee2000 270bc43
Remove store seq diagram
WilsonLee2000 0745ec5
Fix bug for Parser
YC-Michael b504fe3
Merge pull request #302 from WilsonLee2000/fixstoreseqdiagram
WilsonLee2000 88b83f1
Fix bug for Parser
YC-Michael 3ae966a
add header comment
ZiqiuZeng 741201f
Added Store Sequence Diagram
WilsonLee2000 29b4596
Merge pull request #303 from YC-Michael/master
YC-Michael 11ddfdb
Merge pull request #305 from WilsonLee2000/StoreSequenceDiagram
WilsonLee2000 6d7bf59
Merge pull request #304 from ZiqiuZeng/update-header-comment
ZiqiuZeng 5ed0428
Merge branch 'StoreSequenceDiagram'
WilsonLee2000 028412e
Merge branch 'master' of https://github.com/AY2223S2-CS2113-F10-2/tp
WilsonLee2000 e7be577
Remove Store Seq Diagram
WilsonLee2000 446871d
Merge pull request #306 from WilsonLee2000/seqdiagramrectify
WilsonLee2000 d726cb4
Add Seq Diagram for Store
WilsonLee2000 eeac598
Merge pull request #307 from WilsonLee2000/SeqDiagramAdd
WilsonLee2000 f15b2ec
Merge branch 'SeqDiagramAdd'
WilsonLee2000 c99999a
Fix UI Naming Error
WilsonLee2000 c346fc1
Merge pull request #308 from WilsonLee2000/fixuibug
WilsonLee2000 477be31
Update UserGuide.md
0nandon 43fc0f9
Merge pull request #309 from 0nandon/master
0nandon a0dddb0
Update 0nandon.md
0nandon 187283a
Update 0nandon.md
0nandon 8c1692e
Merge pull request #310 from 0nandon/master
0nandon a35469d
Update DeveloperGuide.md
0nandon 1472079
Update DeveloperGuide.md
0nandon 5041060
Fix format
YC-Michael 9a629fd
Merge pull request #311 from 0nandon/master
0nandon 989821c
handle indentation problem
ZiqiuZeng 195b515
Merge pull request #312 from YC-Michael/master
YC-Michael 42496d5
Merge pull request #313 from ZiqiuZeng/refine-dg
ZiqiuZeng c726548
Update DeveloperGuide.md
0nandon 8105036
Update DeveloperGuide.md
0nandon 4fb9cb4
Merge pull request #314 from 0nandon/master
0nandon 7823156
Add JavaDoc comments for the matrix part
CVRP-SOLE 7586d3f
Merge pull request #315 from 0nandon/master
0nandon c4bc080
change main README.md to BadMaths version
CVRP-SOLE db52353
Merge pull request #316 from 0nandon/master
0nandon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes
File renamed without changes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concise and clear explanation of what your features does in this section! Consider explaining why you implemented your feature logic this way, maybe even describing some alternative implementations you considered but ultimately dropped, which would strengthen the appeal of your features to a developer.