-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS2113-T12-2] Big-PP #23
base: master
Are you sure you want to change the base?
[CS2113-T12-2] Big-PP #23
Conversation
…Storage Merge Storage to master
Developer Guide Viewer Add Command sequence diagram
Compatibility check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good explanation, but class diagrams tend to be excessively detailed to the point that they cannot be read without zooming in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall really nice DG :) I liked how some of the classes use a Initialization, Functionality, Behavior structure
![Viewer Add Command Sequential Diagram](uml-pictures/ViewerAddCommand.png) | ||
### PC Class Architecture | ||
|
||
![PC Class Diagram](uml-pictures/PcDiagram.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
{list here sources of all reused/adapted ideas, code, documentation, and third-party libraries -- include links to the original source as well} | ||
### UI class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a multiplicity needs to be added between UI and UIState as well.
Bugs with filter command
…mmands Update ViewerHelpCommand to include filter commands Update return message in PCList
Minor changes to price handling
Fix bugs for exception message in listcommand
Fix userguide and Dg
Handle ParseFloat infinity
This is a command-line tool designed to help you pick computer parts based on your needs and budget.