-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tahsinhasem iP #534
Open
tahsinhasem
wants to merge
168
commits into
nus-cs2103-AY2324S2:master
Choose a base branch
from
tahsinhasem:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
tahsinhasem iP #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature
adding assertions to main code
There were no assertions in the Commands that were being implemented in dude. Especially the constructors, where many of the constructions were assuming certain conditions to hold true. Conditions that the command class sub-class constructors assumed to be true: * String input : Assumed to be not null, assumed to contain appropriate command * Tasklist tasklist: Assumed to be not null Now assertions have been added to the constructors to make sure such conditions are actually holding true. These assertions will help to reduce bugs making sure the conditions assumed to be true, actually hold true. I believe this will drastically reduce bugs when I decide to add on more features.
Currently, tasks are stored such that they are ordered by when tasks are added into dude by user. It has no order. The ordering of the tasks are necessary as it is a relevant information to the user. I have modified Dude in such a way that it sorts the tasks added by time, every time a new task is added to added it dude. The Tasks are sorted by By-Dates (if Deadline Task) or From-Date (for event tasks). Todo tasks are sorted by which one was last added. Now the user will get a sorted task list everywhere in the program, allowing the user to see tasks chronologically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dude 💪
A
easykinda easy to use cli task manager.Features
Why should you use it?
Its as easy as:
where
Dude
is the main class of this program.Advanced Features