[kenzantonius] iP #378

kenzantonius · 2023-02-01T07:05:43Z

DukePro

“Your mind is for having ideas, not holding them.” – David Allen (source)

DukePro frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

WilliamHaiweiGu

Coding standard is decent.

Compliant with information hiding and encapsulation. No public class variables.
Boolean variables start with "is".
Indentation is strictly 4 whitespaces.
Line length is never no longer than 120 chars.
Strictly follows Egyptian style brackets and correct letter case for most names.
Appropriate whitespaces within statements.
All variables are initialized at declaration.

Some rooms for improvement:

Minor naming errors.
Should put every class in a package.
Documentation plz 🥺

GJ!

WilliamHaiweiGu · 2023-02-01T09:29:53Z

src/main/java/Duke.java

 public class Duke {
+    private Scanner scanner = new Scanner(System.in);
+    private ArrayList<Task> list = new ArrayList<>();
+    private void Input() {


Shouldn't this method name be in camelCase?

WilliamHaiweiGu · 2023-02-01T09:47:33Z

src/main/java/Duke.java

+    }
+
+    private String[] ErrorEventOrDeadline(String input, String textToReplace, String textToSplit) throws DukeException {
+        String[] splitInput = input.replaceFirst(textToReplace, "")


Maybe use plural form for array name?

WilliamHaiweiGu · 2023-02-01T09:49:18Z

src/main/java/Duke.java

+        }
+    }
+
+    private String[] ErrorEventOrDeadline(String input, String textToReplace, String textToSplit) throws DukeException {


Maybe use verbs and camelCase for method names? Say, "makeErrEventOrDdl"

WilliamHaiweiGu · 2023-02-01T09:55:22Z

src/main/java/Duke.java

 public class Duke {
+    private Scanner scanner = new Scanner(System.in);
+    private ArrayList<Task> list = new ArrayList<>();


Maybe use plural form in a collection name? Like "tasks"?

WilliamHaiweiGu · 2023-02-01T10:15:24Z

src/main/java/Duke.java

+                    continue;
+                }
+                if (userInput.startsWith("deadline")) {
+                    String[] deadline = ErrorEventOrDeadline(userInput, "deadline", "/by");


Maybe use plural form for array name?

WilliamHaiweiGu · 2023-02-01T10:15:28Z

src/main/java/Duke.java

+                    continue;
+                }
+                if (userInput.startsWith("event")) {
+                    String[] event = ErrorEventOrDeadline(userInput, "event", "/at");


Maybe use plural form for array name?

seadragon2000341

Overall, good job! Code is neat and follows coding standards

seadragon2000341 · 2023-02-02T05:46:17Z

src/main/java/Deadline.java

@@ -0,0 +1,14 @@
+public class Deadline extends Task {
+
+    protected String by;


Maybe change name from by to something that is a noun

seadragon2000341 · 2023-02-02T05:48:11Z

src/main/java/Event.java

@@ -0,0 +1,13 @@
+public class Event extends Task {
+    private String from;


similarly, conisder changing from to a noun

seadragon2000341 · 2023-02-02T05:48:48Z

src/main/java/Task.java

@@ -0,0 +1,26 @@
+public class Task {
+    protected String description;
+    protected boolean isDone;


nice following convention

… keyword.

Command classes have some complicated expressions. This might confuse the reader of the code. The expressions are changed into boolean variables with names that are self-explanatory so that the code can be easily understood. Other parts of the code already follow the code quality, so no changes are made.

Use Assertions.

Improve code quality.

damithc and others added 7 commits July 31, 2022 17:20

Add Gradle support

556af3f

Add Level 1

d0da323

Add Level 2

9395dc6

Add Level 3

2a3787e

Add Level 4

c76707f

Add level 5

2d45761

Add level 6

5b12a41

WilliamHaiweiGu reviewed Feb 1, 2023

View reviewed changes

seadragon2000341 reviewed Feb 2, 2023

View reviewed changes

kenzantonius added 21 commits February 13, 2023 18:42

Add level 7

5506608

Add level 8

30e51fb

no message

e125b5f

Merge branch 'branch-Level-7'

c47d8ac

no message

462d127

Merge branch 'branch-Level-8'

502bbbc

Make the code more OOP

cedbe55

Merge branch 'branch-A-MoreOOP'

14a39a6

Divide classes into packages

0843b84

Merge branch 'branch-A-Packages'

1fcdf42

Merge branch 'add-gradle-support'

1bbfa6a

Add JUnit tests to test the behavior of the code

f8939fc

Add JavaDoc comments to the code.

90e04a4

Merge branch 'branch-A-JavaDoc'

96be1dc

Tweak the code to comply with a coding standard.

e864b36

Merge branch 'branch-A-CodingStandard'

d70d794

Implement Level 9. Give users a way to find a task by searching for a…

44be10d

… keyword.

Merge branch 'branch-Level-9'

fb0b9d4

Implement Level 10. Add a GUI to Duke.

710f5ef

Merge branch 'branch-Level-10'

bbce7ed

Use Assertions.

913f4bf

kenzantonius and others added 8 commits February 20, 2023 21:30

Merge pull request #2 from kenzantonius/branch-A-Assertions

3f90dae

Use Assertions.

Merge pull request #3 from kenzantonius/branch-A-CodeQuality

2ba8057

Improve code quality.

Merge branch 'master' of https://github.com/kenzantonius/ip

e16deb6

Add Ui.png.

0e40946

Update README.md

cd96457

Merge branch 'master' of https://github.com/kenzantonius/ip

6bd37c2

Fix bugs.

94f55bf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[kenzantonius] iP #378

[kenzantonius] iP #378

kenzantonius commented Feb 1, 2023 •

edited

Loading

WilliamHaiweiGu left a comment •

edited

Loading

WilliamHaiweiGu Feb 1, 2023

WilliamHaiweiGu Feb 1, 2023

WilliamHaiweiGu Feb 1, 2023

WilliamHaiweiGu Feb 1, 2023

WilliamHaiweiGu Feb 1, 2023

WilliamHaiweiGu Feb 1, 2023

seadragon2000341 left a comment

seadragon2000341 Feb 2, 2023

seadragon2000341 Feb 2, 2023

seadragon2000341 Feb 2, 2023

		@@ -0,0 +1,14 @@
		public class Deadline extends Task {

		protected String by;

		@@ -0,0 +1,13 @@
		public class Event extends Task {
		private String from;

[kenzantonius] iP #378

Are you sure you want to change the base?

[kenzantonius] iP #378

Conversation

kenzantonius commented Feb 1, 2023 • edited Loading

DukePro

WilliamHaiweiGu left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seadragon2000341 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kenzantonius commented Feb 1, 2023 •

edited

Loading

WilliamHaiweiGu left a comment •

edited

Loading