-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ryanchua00] iP #363
base: master
Are you sure you want to change the base?
[ryanchua00] iP #363
Conversation
- Added "this." to object-specific fields
- Changed bat file to keep prompt open
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on implementing Roody.java, perhaps adding some more OOP like classes would be good!
# Conflicts: # src/main/java/Deadline.java # src/main/java/Event.java # src/main/java/Roody.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code is intuitive and very easy to read. Good Job!
src/main/java/roody/Roody.java
Outdated
} | ||
|
||
// toggles completion status of tasks | ||
private void complete(int index, boolean complete) throws RoodyException{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps a javadoc @param comment here would be helpful to explain why boolean complete is needed
src/main/java/roody/Roody.java
Outdated
} | ||
|
||
|
||
private void delete(int index) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A more intuitive name here would be great
private void delete(int index) { | |
private void deleteTask(int index) { |
# Conflicts: # src/main/java/roody/Deadline.java # src/main/java/roody/Roody.java # src/main/java/roody/Storage.java # src/main/java/roody/Task.java # src/main/java/roody/Todo.java
# Conflicts: # src/main/java/roody/Deadline.java # src/main/java/roody/Event.java # src/main/java/roody/Parser.java # src/main/java/roody/Roody.java # src/main/java/roody/Todo.java # src/main/java/roody/Ui.java
Add GUI Added classes to handle GUI and changed Roody.java to launch GUI. Depreciated CLI and UI functions were either removed or converted to a String-based message format to pass to the GUI. Improve switch flow in Roody.java Methods in switch cases were extracted to individual methods. Error handling to be improved to consolidate try-catch blocks.
Handle exceptions in Parser.java While Roody.java used to handle exceptions and execute methods, exception handling has been shifted to Parser.java for ease of understanding. Only parsed input is passed to Roody.java, simplifying command flow. Add more custom exceptions and constants To reduce repeated strings and literals, custom exceptions with fixed messages have been added for easier throwing and usage. Constants have also been added to reduce magic literals. *Roody.java *Parser.java
Commands to carry out individual tasks captured by abstract Command.java class and inherited by child command classes. This classes override execute method, allowing for a single method to be called in Roody.java Check input format and create command Parser.java now checks format of commands first before creating the relevant commands and passing it back to Roody.java. Roody.java now does not know the exact command, only that it is a command.
Branch-A-code quality
# Conflicts: # src/main/java/roody/Parser.java # src/main/java/roody/Storage.java
Branch-A-Assertions
According to workflow
Add help functionality
Improved code quality according to issue posted by bot. Applied SLAP and renamed relevant variables.
Added infinite dialog length and removed dead code.
Add Ui.png Improve GUI
Roody Application
The Roody application helps frees your mind of having to remember things you need to do. It's,
FASTSUPERFAST to use!All you need to do is,
And it is FREE!
Features:
If you Java programmer, you can use it to practice Java too. Here's the
constructor
for Roody method: