Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] connector_oxigesti: export manufacturing and unbuild orders #301

Open
wants to merge 9 commits into
base: 14.0
Choose a base branch
from

Conversation

FrankC013
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Attention: Patch coverage is 43.14721% with 112 lines in your changes are missing coverage. Please review.

Project coverage is 46.35%. Comparing base (46ffd21) to head (50cee39).
Report is 5 commits behind head on 14.0.

❗ Current head 50cee39 differs from pull request most recent head 8ebb248. Consider uploading reports for the commit 8ebb248 to get more accurate results

Files Patch % Lines
...onnector_oxigesti/models/mrp_production/binding.py 34.14% 27 Missing ⚠️
...or_oxigesti/models/mrp_production/export_mapper.py 31.57% 26 Missing ⚠️
connector_oxigesti/components/adapter.py 12.50% 21 Missing ⚠️
...r_oxigesti/models/product_product/export_mapper.py 17.64% 14 Missing ⚠️
...nnector_oxigesti/models/mrp_production/exporter.py 60.86% 9 Missing ⚠️
...gesti/models/stock_production_lot/import_mapper.py 27.27% 8 Missing ⚠️
...nnector_oxigesti/models/oxigesti_backend/common.py 36.36% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             14.0     #301      +/-   ##
==========================================
- Coverage   46.37%   46.35%   -0.03%     
==========================================
  Files         778      785       +7     
  Lines       13628    13824     +196     
  Branches     2984     3024      +40     
==========================================
+ Hits         6320     6408      +88     
- Misses       7143     7253     +110     
+ Partials      165      163       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrankC013 FrankC013 force-pushed the 14.0-add-connector_oxigesti-export_mrp_production_unbuild branch 6 times, most recently from ba942a8 to 865b196 Compare September 22, 2023 09:05
@FrankC013 FrankC013 force-pushed the 14.0-add-connector_oxigesti-export_mrp_production_unbuild branch from 865b196 to 45be0b4 Compare September 22, 2023 13:36
@FrankC013 FrankC013 force-pushed the 14.0-add-connector_oxigesti-export_mrp_production_unbuild branch 3 times, most recently from cf78fd1 to f80e2c3 Compare September 26, 2023 16:39
mssql_type_map = {}
for k, v in self.PYTHON_TYPE_MAP.items():
for t in v:
mssql_type_map[t] = k
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if "t" is already in mssql_type_map, ValidationError if is

Comment on lines 249 to 254
# check if schema exists to avoid injection
schema_exists = self._exec_sql(
"select 1 from sys.schemas where name=%s", (self.schema,)
)
if not schema_exists:
raise pymssql.InternalError("The schema %s does not exist" % self.schema)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these lines, this is covered by the cursor execution itself.

Comment on lines +268 to +263
raise ValidationError(
_("Unexpected type %s for field %s") % (ttype, field)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this line as a first if

@FrankC013 FrankC013 force-pushed the 14.0-add-connector_oxigesti-export_mrp_production_unbuild branch from f80e2c3 to 8199e91 Compare September 27, 2023 06:26
@FrankC013 FrankC013 force-pushed the 14.0-add-connector_oxigesti-export_mrp_production_unbuild branch from 02f0896 to 35eadd1 Compare November 21, 2023 17:10
@FrankC013 FrankC013 requested a review from eantones February 9, 2024 10:30
@FrankC013 FrankC013 force-pushed the 14.0-add-connector_oxigesti-export_mrp_production_unbuild branch 2 times, most recently from 0f77b6f to 8a2795a Compare February 9, 2024 11:07
@eantones eantones force-pushed the 14.0-add-connector_oxigesti-export_mrp_production_unbuild branch from 8a2795a to 50cee39 Compare March 4, 2024 20:55
@eantones eantones force-pushed the 14.0-add-connector_oxigesti-export_mrp_production_unbuild branch from 50cee39 to 8ebb248 Compare May 15, 2024 16:42
@eantones eantones force-pushed the 14.0-add-connector_oxigesti-export_mrp_production_unbuild branch from 8ebb248 to 1960b75 Compare October 10, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants