[IMP] website_sale_product_document: minor refactor

nuobit · Oct 26, 2023 · 730f3c5 · 730f3c5
1 parent 41fd8e8
commit 730f3c5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/website_sale_product_document/models/product_document.py b/website_sale_product_document/models/product_document.py
@@ -38,7 +38,6 @@ def _compute_attachment_id(self):
             )
             if not attachment:
                 raise ValidationError(_("No attachment found"))
-            elif len(attachment) > 1:
+            if len(attachment) > 1:
                 raise ValidationError(_("More than one attachment found"))
-            else:
-                rec.attachment_id = attachment[0]
+            rec.attachment_id = attachment[0]
diff --git a/website_sale_product_document/views/product_template_views.xml b/website_sale_product_document/views/product_template_views.xml
@@ -1,6 +1,8 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <!-- Copyright NuoBiT Solutions - Kilian Niubo <[email protected]>
      License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl) -->
+<!--TODO: REVIEW: This view and product_product_views in this module are equivalent.
+        Try to unify them https://www.odoo.com/documentation/14.0/developer/reference/addons/views.html#inheritance-fields-->
 <odoo>
     <record
         id="website_sale_public_description_product_template_view_form"
@@ -17,7 +19,7 @@
                             <field name="sequence" widget="handle" />
                             <field name="name" />
                             <field name="datas" filename="datas_fname" />
-                             <field name="datas_fname" />
+                            <field name="datas_fname" />
                         </tree>
                     </field>
                 </group>